From: Mark Brown <broonie@kernel.org>
To: Lina Iyer <lina.iyer@linaro.org>
Cc: Georgi Djakov <georgi.djakov@linaro.org>,
lgirdwood@gmail.com, andy.gross@linaro.org, sboyd@codeaurora.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators
Date: Wed, 10 Feb 2016 10:13:40 +0000 [thread overview]
Message-ID: <20160210101340.GU13270@sirena.org.uk> (raw)
In-Reply-To: <20160209222154.GB1646@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
On Tue, Feb 09, 2016 at 03:21:54PM -0700, Lina Iyer wrote:
> On Tue, Feb 09 2016 at 06:13 -0700, Georgi Djakov wrote:
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
> >+#define SPM_REG_STS_1 0x10
> >+#define SPM_REG_VCTL 0x14
> >+#define SPM_REG_PMIC_DATA_0 0x28
> >+#define SPM_REG_PMIC_DATA_1 0x2c
> >+#define SPM_REG_RST 0x30
> These register offsets are SoC specific. You may want to follow the model
> of drivers/soc/qcom/spm.c in getting register offsets.
> While I see that you are only supporting APQ8064 with this patch, you
> probably would want to think a bit far ahead. To support any other QCOM
> SoC, you would need extensive changes.
This has already been applied. It's not immediately clear to me that
changes simply to move the registers around would be more extensive than
just adding fields to the driver data, is it more than just that?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-10 10:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 13:12 [PATCH v4] regulator: qcom-saw: Add support for SAW regulators Georgi Djakov
2016-02-09 18:20 ` Applied "regulator: qcom-saw: Add support for SAW regulators" to the regulator tree Mark Brown
2016-02-09 22:21 ` [PATCH v4] regulator: qcom-saw: Add support for SAW regulators Lina Iyer
2016-02-10 10:13 ` Mark Brown [this message]
2016-02-10 16:42 ` Lina Iyer
2016-02-10 18:54 ` Mark Brown
2016-02-10 12:52 ` Georgi Djakov
2016-02-10 18:36 ` Stephen Boyd
2016-02-10 18:43 ` Mark Brown
2016-02-10 19:04 ` Stephen Boyd
2016-02-10 19:21 ` Mark Brown
2016-02-10 22:46 ` Stephen Boyd
2016-02-11 10:17 ` Georgi Djakov
2016-02-12 0:17 ` Stephen Boyd
2016-02-12 23:03 ` Mark Brown
2016-02-19 16:07 ` Mark Brown
2016-03-15 9:29 ` Applied "regulator: qcom-saw: Add support for SAW regulators" to the regulator tree Mark Brown
2016-03-15 9:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210101340.GU13270@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.gross@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.