From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 2/8] xen/misc: Remove or annotate possibly-unused functions Date: Wed, 10 Feb 2016 10:42:10 +0000 Message-ID: <20160210104210.GA12777@deinos.phlegethon.org> References: <1455048108-5045-1-git-send-email-andrew.cooper3@citrix.com> <1455048108-5045-3-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1455048108-5045-3-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Ian Campbell , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org At 20:01 +0000 on 09 Feb (1455048102), Andrew Cooper wrote: > Clang notices more unused functions than GCC. > > * sh_next_page() is only used at GUEST_PAGING_LEVELS=2, so remove it from the > other guest level translation units > * rcu_batch_after() is completely unused. > * Various of the COMPAT() generated functions are used only for their > BUILD_BUG_ON() properties. Annotate them all as __maybe_used. > > Signed-off-by: Andrew Cooper Shadow stuff Acked-by: Tim Deegan