From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754687AbcBJLvb (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Feb 2016 06:51:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35381 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753631AbcBJLv3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Feb 2016 06:51:29 -0500
Date: Wed, 10 Feb 2016 12:51:22 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 13/23] perf hists: Support filtering in hierarchy mode
Message-ID: <20160210115122.GA19907@krava.redhat.com>
References: <1454677315-7515-1-git-send-email-namhyung@kernel.org>
 <1454677315-7515-14-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454677315-7515-14-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 05, 2016 at 10:01:45PM +0900, Namhyung Kim wrote:

SNIP

> +			parent = parent->parent_he;
> +		}
> +	}
> +
>  	if (h->filtered)
>  		return;
>  
> @@ -1592,28 +1613,122 @@ static void hists__filter_by_type(struct hists *hists, int type, filter_fn_t fil
>  	}
>  }
>  
> +static void hists__filter_hierarchy(struct hists *hists, int type, const void *arg)
> +{
> +	struct rb_node *nd;
> +	struct rb_root tmp = RB_ROOT;
> +	bool saved_unfolded;
> +
> +	hists->stats.nr_non_filtered_samples = 0;
> +
> +	hists__reset_filter_stats(hists);
> +	hists__reset_col_len(hists);
> +
> +	nd = rb_first(&hists->entries);
> +	while (nd) {
> +		struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node);
> +		int ret;
> +
> +		ret = hist_entry__filter(h, type, arg);
> +
> +		/*
> +		 * case 1. non-matching type
> +		 * zero out the period, set filtered and move to child
> +		 */
> +		if (ret < 0) {
> +			memset(&h->stat, 0, sizeof(h->stat));
> +			h->filtered |= (1 << type);
> +
> +			/* force to go down in the hierarchy */
> +			saved_unfolded = h->unfolded;
> +			h->unfolded = true;
> +
> +			nd = rb_hierarchy_next(&h->rb_node);
> +			h->unfolded = saved_unfolded;
> +		}
> +		/*
> +		 * case 2. matched (filter out)
> +		 * set filtered and move to next
> +		 */
> +		else if (ret == 1) {

slightly confused in here.. so ret == 1 means we matched
but for example hist_entry__sym_filter:

+       return sym && (!he->ms.sym || !strstr(he->ms.sym->name, sym));

returns 1 if we DONT match the symbol

I always got confused by non/filtered stuff.. I think we should change
the those names, but haven't come with anything so far..

jirka