From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750844AbcBJMNq (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Feb 2016 07:13:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45349 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750713AbcBJMNm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Feb 2016 07:13:42 -0500
Date: Wed, 10 Feb 2016 13:13:35 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode
Message-ID: <20160210121335.GC19907@krava.redhat.com>
References: <1454677315-7515-1-git-send-email-namhyung@kernel.org>
 <1454677315-7515-15-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454677315-7515-15-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote:

SNIP

> +	printed += fprintf(fp, "%s\n", buf);
> +
> +	if (symbol_conf.use_callchain && he->leaf) {
> +		u64 total = hists__total_period(hists);
> +
> +		printed += hist_entry_callchain__fprintf(he, total, 0, fp);
> +		goto out;
> +	}
> +
> +out:
> +	return printed;
> +}
> +
>  static int hist_entry__fprintf(struct hist_entry *he, size_t size,
>  			       struct hists *hists,
>  			       char *bf, size_t bfsz, FILE *fp)
> @@ -423,6 +488,13 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size,
>  	if (size == 0 || size > bfsz)
>  		size = hpp.size = bfsz;
>  
> +	if (symbol_conf.report_hierarchy) {

it'd be great for review to have symbol_conf.report_hierarchy already
present, so I could try it early in the patchset like with this change

jirka