From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751752AbcBJOR3 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Feb 2016 09:17:29 -0500
Received: from mail-pa0-f66.google.com ([209.85.220.66]:33628 "EHLO
	mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751414AbcBJOR2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Feb 2016 09:17:28 -0500
Date: Wed, 10 Feb 2016 23:16:16 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 13/23] perf hists: Support filtering in hierarchy mode
Message-ID: <20160210141616.GA4301@danjae.kornet>
References: <1454677315-7515-1-git-send-email-namhyung@kernel.org>
 <1454677315-7515-14-git-send-email-namhyung@kernel.org>
 <20160210121119.GB19907@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160210121119.GB19907@krava.redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 10, 2016 at 01:11:19PM +0100, Jiri Olsa wrote:
> On Fri, Feb 05, 2016 at 10:01:45PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > +			/* force to go to sibling in the hierarchy */
> > +			saved_unfolded = h->unfolded;
> > +			h->unfolded = false;
> > +
> > +			nd = rb_hierarchy_next(&h->rb_node);
> > +			h->unfolded = saved_unfolded;
> > +		}
> > +	}
> > +
> > +	/* resort output (top-level entries only) */
> > +	nd = rb_first(&hists->entries);
> > +	while (nd) {
> > +		struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node);
> > +
> > +		nd = rb_next(nd);
> > +		rb_erase(&h->rb_node, &hists->entries);
> > +
> > +		__hists__insert_output_entry(&tmp, h, 0, false);
> > +	}
> 
> what's the purpose of this resort? the only affect I see
> is to recalculate callchains

Filter can change parent entries' period so we need to resort after
applying a filter and this is why I pass 'false' for the
'use_callchain' param.

For example, let's say there're two top-level entries: A and B.  The A
has 40% overhead and the B has 30%.  But after applying filter the A
can have 10% and the B can have 15%.  So output should be changed to
put the B before the A.

I'll add a comment for this.

Thanks,
Namhyung