From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751821AbcBJOWu (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Feb 2016 09:22:50 -0500
Received: from mail-pa0-f67.google.com ([209.85.220.67]:36559 "EHLO
	mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751320AbcBJOWs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Feb 2016 09:22:48 -0500
Date: Wed, 10 Feb 2016 23:21:37 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode
Message-ID: <20160210142137.GB4301@danjae.kornet>
References: <1454677315-7515-1-git-send-email-namhyung@kernel.org>
 <1454677315-7515-15-git-send-email-namhyung@kernel.org>
 <20160209220117.GA3030@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160209220117.GA3030@krava.redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 09, 2016 at 11:01:17PM +0100, Jiri Olsa wrote:
> On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote:
> > The hierarchy output mode is to group entries for each level so that
> > user can see higher level picture more easily.  It also helps to find
> > out which component is most costly.  The output will look like below:
> > 
> >       15.11%     swapper
> >          14.97%     [kernel.vmlinux]
> >           0.09%     [libahci]
> >           0.05%     [iwlwifi]
> >       10.29%     irq/33-iwlwifi
> >           6.45%     [kernel.vmlinux]
> >           1.41%     [mac80211]
> >           1.15%     [iwldvm]
> >           1.14%     [iwlwifi]
> >           0.14%     [cfg80211]
> >        4.81%     firefox
> >           3.92%     libxul.so
> >           0.34%     [kernel.vmlinux]
> > 
> > Acked-by: Pekka Enberg <penberg@kernel.org>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---
> >  tools/perf/ui/hist.c       | 14 +++++++++
> >  tools/perf/ui/stdio/hist.c | 77 +++++++++++++++++++++++++++++++++++++++++++++-
> >  tools/perf/util/hist.h     |  4 +++
> >  3 files changed, 94 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
> > index 1ba4117d9c2d..c398ce288615 100644
> > --- a/tools/perf/ui/hist.c
> > +++ b/tools/perf/ui/hist.c
> > @@ -687,3 +687,17 @@ void perf_hpp__set_user_width(const char *width_list_str)
> >  			break;
> >  	}
> >  }
> > +
> > +int perf_hpp__count_sort_keys(void)
> > +{
> > +	int nr_sort = 0;
> > +	struct perf_hpp_fmt *fmt;
> > +
> > +	perf_hpp_list__for_each_format(&perf_hpp_list, fmt) {
> > +		if (perf_hpp__is_sort_entry(fmt) ||
> > +		    perf_hpp__is_dynamic_entry(fmt))
> > +			nr_sort++;
> > +	}
> > +
> > +	return nr_sort;
> > +}
> 
> hum, this seems expensive..  also we should do that
> in generic way per perf_hpp_list struct

OK.  But this is not called frequently though..

> 
> we could hold number of sort entries in struct perf_hpp_list
> and count it in:
>   perf_hpp_list__register_sort_field

OK.

Thanks,
Namhyung