From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v2 5/5] ARM: dts: r8a7794: add sound support Date: Wed, 10 Feb 2016 18:14:55 +0100 Message-ID: <20160210171455.GB17671@verge.net.au> References: <12033353.rt0nolnBmD@wasted.cogentembedded.com> <2543047.yYrDdYb9v5@wasted.cogentembedded.com> <874mdhtn7d.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <874mdhtn7d.wl%kuninori.morimoto.gx@renesas.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: Kuninori Morimoto Cc: Sergei Shtylyov , linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Wed, Feb 10, 2016 at 12:41:30AM +0000, Kuninori Morimoto wrote: > > Hi Sergei > > Sorry for my un-ordered response > > > Define the generic R8A7794 part of the sound device node. > > This sound device is a complex one and comprises the Audio Clock Generator > > (ADG), Sampling Rate Converter Unit (SCU), Serial Sound Interface [Unit] > > (SSI[U]), and Audio DMAC-Peripheral-Peripheral. > > It is up to the board file to enable the device. > > > > This patch is based on the R8A7791 sound work by Kuninori Morimoto. > > > > Signed-off-by: Sergei Shtylyov > (snip) > > + rcar_sound,src { > > + src1: src@1 { > > + interrupts = ; > > + dmas = <&audma0 0x87>, <&audma0 0x9c>; > > + dma-names = "rx", "tx"; > > + }; > > + src2: src@2 { > > + interrupts = ; > > + dmas = <&audma0 0x89>, <&audma0 0x9e>; > > + dma-names = "rx", "tx"; > > + }; > > + src3: src@3 { > > + interrupts = ; > > + dmas = <&audma0 0x8b>, <&audma0 0xa0>; > > + dma-names = "rx", "tx"; > > + }; > > + src4: src@4 { > > + interrupts = ; > > + dmas = <&audma0 0x8d>, <&audma0 0xb0>; > > + dma-names = "rx", "tx"; > > + }; > > + src5: src@5 { > > + interrupts = ; > > + dmas = <&audma0 0x8f>, <&audma0 0xb2>; > > + dma-names = "rx", "tx"; > > + }; > > + src6: src@6 { > > + interrupts = ; > > + dmas = <&audma0 0x91>, <&audma0 0xb4>; > > + dma-names = "rx", "tx"; > > + }; > > + }; > > I think this can't work correctly, because driver is assuming > DT has all channles (from 0). (see linux/sound/soc/sh/rcar/src.c :: rsnd_src_probe) > Can you adds dummy src0 with some comments ? or fix src.c driver ? I would prefer the driver to be fixed (I had a similar patchset locally and I found it doesn't work). The reason is that DT should describe the hardware rather than the current state of the software. From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Wed, 10 Feb 2016 18:14:55 +0100 Subject: [PATCH v2 5/5] ARM: dts: r8a7794: add sound support In-Reply-To: <874mdhtn7d.wl%kuninori.morimoto.gx@renesas.com> References: <12033353.rt0nolnBmD@wasted.cogentembedded.com> <2543047.yYrDdYb9v5@wasted.cogentembedded.com> <874mdhtn7d.wl%kuninori.morimoto.gx@renesas.com> Message-ID: <20160210171455.GB17671@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 10, 2016 at 12:41:30AM +0000, Kuninori Morimoto wrote: > > Hi Sergei > > Sorry for my un-ordered response > > > Define the generic R8A7794 part of the sound device node. > > This sound device is a complex one and comprises the Audio Clock Generator > > (ADG), Sampling Rate Converter Unit (SCU), Serial Sound Interface [Unit] > > (SSI[U]), and Audio DMAC-Peripheral-Peripheral. > > It is up to the board file to enable the device. > > > > This patch is based on the R8A7791 sound work by Kuninori Morimoto. > > > > Signed-off-by: Sergei Shtylyov > (snip) > > + rcar_sound,src { > > + src1: src at 1 { > > + interrupts = ; > > + dmas = <&audma0 0x87>, <&audma0 0x9c>; > > + dma-names = "rx", "tx"; > > + }; > > + src2: src at 2 { > > + interrupts = ; > > + dmas = <&audma0 0x89>, <&audma0 0x9e>; > > + dma-names = "rx", "tx"; > > + }; > > + src3: src at 3 { > > + interrupts = ; > > + dmas = <&audma0 0x8b>, <&audma0 0xa0>; > > + dma-names = "rx", "tx"; > > + }; > > + src4: src at 4 { > > + interrupts = ; > > + dmas = <&audma0 0x8d>, <&audma0 0xb0>; > > + dma-names = "rx", "tx"; > > + }; > > + src5: src at 5 { > > + interrupts = ; > > + dmas = <&audma0 0x8f>, <&audma0 0xb2>; > > + dma-names = "rx", "tx"; > > + }; > > + src6: src at 6 { > > + interrupts = ; > > + dmas = <&audma0 0x91>, <&audma0 0xb4>; > > + dma-names = "rx", "tx"; > > + }; > > + }; > > I think this can't work correctly, because driver is assuming > DT has all channles (from 0). (see linux/sound/soc/sh/rcar/src.c :: rsnd_src_probe) > Can you adds dummy src0 with some comments ? or fix src.c driver ? I would prefer the driver to be fixed (I had a similar patchset locally and I found it doesn't work). The reason is that DT should describe the hardware rather than the current state of the software.