From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751859AbcBKOKx (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Feb 2016 09:10:53 -0500
Received: from mga01.intel.com ([192.55.52.88]:11866 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751601AbcBKOKv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Feb 2016 09:10:51 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,431,1449561600"; 
   d="scan'208";a="882077816"
Date: Thu, 11 Feb 2016 16:10:14 +0200
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Oliver Neukum <oneukum@suse.de>, Felipe Balbi <balbi@kernel.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        USB <linux-usb@vger.kernel.org>
Subject: Re: Fwd: [PATCH 2/3] usb: type-c: USB Type-C Connector System
 Software Interface
Message-ID: <20160211141014.GD32213@kuha.fi.intel.com>
References: <1455037283-106479-1-git-send-email-heikki.krogerus@linux.intel.com>
 <1455037283-106479-3-git-send-email-heikki.krogerus@linux.intel.com>
 <CAHp75VeUt_uRgxQDxzMw3uoqaRC3TDEyVt1xDSGUicACf4H-_A@mail.gmail.com>
 <1455113742.8878.14.camel@suse.com>
 <CAHp75VcuDpUtEKihpu1uAfkVKuf6eOjrt6Y4VwWE0wcYoN3ERQ@mail.gmail.com>
 <1455116893.8878.15.camel@suse.de>
 <CAHp75VfmGsskf7Cmni3b4=tCbkPsR8d3jPYiv93Lm6DM9gq1-g@mail.gmail.com>
 <CAHp75VdnYbJRaYLCC2T1HAkexhExW6Br4r68R5C+_v7K7TD-6A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75VdnYbJRaYLCC2T1HAkexhExW6Br4r68R5C+_v7K7TD-6A@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 11, 2016 at 10:13:11AM +0200, Andy Shevchenko wrote:
> ---------- Forwarded message ----------
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Date: Thu, Feb 11, 2016 at 10:10 AM
> Subject: Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System
> Software Interface
> To: Oliver Neukum <oneukum@suse.de>
> 
> 
> On Wed, Feb 10, 2016 at 5:08 PM, Oliver Neukum <oneukum@suse.de> wrote:
> > On Wed, 2016-02-10 at 16:24 +0200, Andy Shevchenko wrote:
> >> On Wed, Feb 10, 2016 at 4:15 PM, Oliver Neukum <oneukum@suse.com> wrote:
> >> > On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote:
> >> >> > +err:
> >> >> > +       if (i > 0)
> >> >> > +               for (; i >= 0; i--, con--)
> >> >> > +                       typec_unregister_port(con->port);
> >> >>
> >> >> Perhaps
> >> >>
> >> >> while (--i >= 0) {
> >> >>  ...
> >> >> }
> >> >
> >> > While we are at it. No we should not change the semantics
> >> > of conditionals for the sake of appearance.
> >>
> >> I'm sorry I didn't get you.
> >> How this more or less standard pattern to clean up stuff on error path
> >> does with conditional semantics?
> >
> > You change a postdecrement to a predecrement. The highest
> > number the loop is executed for is changed.
> 
> I still didn't get.
> Variable i is just counter here,
> 
> And it seems there is a bug, since when i == 1, we will have
> 
> i = 1, con == connector[0]:
> typec_unregister_port(con->port);
> 
> i = 0, con == connector[1]:
> typec_unregister_port(con->port); <<< It wasn't registered yet!
> 
> The correct code should be something like
> if (i > 0)
>  for (--i; i >= 0; i--) {}
> 
> Which
> a) makes conditional redundant;
> b) classical pattern of while (--i >= 0) {}
> 
> So where am I wrong?

I think Andy has a point here.

Thanks,

-- 
heikki