From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbcBKOii (ORCPT ); Thu, 11 Feb 2016 09:38:38 -0500 Received: from mga01.intel.com ([192.55.52.88]:33894 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381AbcBKOih (ORCPT ); Thu, 11 Feb 2016 09:38:37 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,431,1449561600"; d="scan'208";a="650689964" Date: Thu, 11 Feb 2016 16:36:16 +0200 From: Heikki Krogerus To: Felipe Balbi Cc: Oliver Neukum , Greg KH , Mathias Nyman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 1/3] usb: USB Type-C Connector Class Message-ID: <20160211143616.GE32213@kuha.fi.intel.com> References: <1455037283-106479-1-git-send-email-heikki.krogerus@linux.intel.com> <1455037283-106479-2-git-send-email-heikki.krogerus@linux.intel.com> <1455101342.8878.5.camel@suse.com> <8737szsk23.fsf@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8737szsk23.fsf@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe, > >> 4. partner_alt_modes - Lists partner's Alternate Modes when connected > > partner_alternate_modes ? (it's a file name, we can spell it out) > > >> 5. partner_type - Can be USB, Charger, Alt Mode or Accessory > >> 6. data_role - The current data role, host or device > >> 7. data_roles - Data roles supported by the connector > > current_data_role > available_data_roles > > >> 8. power_role - Connector's current power role, source or sink > >> 9. power_roles - Power roles supported by the connector > > ditto... > > >> 10. power_operation_mode - The current power level in use > >> 11. usb_pd - yes if the connector supports USB PD. > > supports_usb_power_delivery ? > > >> 12. audio_accessory - yes if the connector supports Audio Accessory > > supports_audio_accessory > > >> 13. debug_accessory - yes if the connector supports Debug Accessory > > supports_debug_accessory Those all make sense. > > Doesn't this need locking? > > And why wouldn't user space want to preselect a mode? > > isn't USB always the default mode ? Just in case there are no misunderstandings here, Oliver was commenting on alternate_mode_store function, and USB of course is not Alternate Mode. Thanks, -- heikki