From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbcBKPAf (ORCPT ); Thu, 11 Feb 2016 10:00:35 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:34273 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbcBKPAd (ORCPT ); Thu, 11 Feb 2016 10:00:33 -0500 Date: Thu, 11 Feb 2016 07:00:28 -0800 From: Eduardo Valentin To: Javi Merino Cc: akpm@linux-foundation.org, rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, drinkcat@chromium.org, Amit Daniel Kachhap Subject: Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle Message-ID: <20160211150027.GA24955@localhost.localdomain> References: <1455192051-6430-1-git-send-email-javi.merino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455192051-6430-1-git-send-email-javi.merino@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2016 at 12:00:51PM +0000, Javi Merino wrote: > In __cpufreq_cooling_register() we allocate the arrays for time_in_idle > and time_in_idle_timestamp to be as big as the number of cpus in this > cpufreq device. However, in get_load() we access this array using the > cpu number as index, which can result in an out of bound access. > > Index time_in_idle{,_timestamp} using the index in the cpufreq_device's > allowed_cpus mask, as we do for the load_cpu array in > cpufreq_get_requested_power() > > Reported-by: Nicolas Boichat > Cc: Amit Daniel Kachhap > Cc: Zhang Rui > Cc: Eduardo Valentin > Tested-by: Nicolas Boichat > Acked-by: Viresh Kumar > Signed-off-by: Javi Merino > --- > Hi Andrew, > > This patch fixes an out of bounds access found by Nicolas Boichat > using KASAN. It is acked by Viresh, comaintainer of the cpu cooling > device and tested by the reporter. It's been in the list[0] for more > than a month, I've pinged the thermal maintainers three times but they > haven't replied. > > Can you merge it via your tree? Thanks, > Javi Somehow this patch was marked as accepted in patchwork and I missed it, apologize for this. I am adding it to thermal-soc. BR, Eduardo