From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTtQe-0004YB-3a for qemu-devel@nongnu.org; Thu, 11 Feb 2016 10:45:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTtQa-0003jz-3t for qemu-devel@nongnu.org; Thu, 11 Feb 2016 10:45:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTtQZ-0003jc-Vf for qemu-devel@nongnu.org; Thu, 11 Feb 2016 10:45:08 -0500 Date: Thu, 11 Feb 2016 15:45:05 +0000 From: Stefan Hajnoczi Message-ID: <20160211154505.GA10359@stefanha-x1.localdomain> References: <1455036545-14870-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline In-Reply-To: <1455036545-14870-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Paolo Bonzini , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-devel@nongnu.org --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 09, 2016 at 07:49:05PM +0300, Denis V. Lunev wrote: > we should call trace_init_backends() before trace_init_file() for > CONFIG_TRACE_SIMPLE There is no difference for other cases. >=20 > This problem was introduced by the commit > commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f > Author: Paolo Bonzini > Date: Thu Jan 7 16:55:24 2016 +0300 >=20 > trace: split trace_init_file out of trace_init_backends >=20 > 'make check' was failed as a result if configured with > --enable-trace-backends=3Dsimple >=20 > Spotted by Alex Benn=E9e. >=20 > Signed-off-by: Denis V. Lunev > CC: Alex Benn=E9e > CC: Paolo Bonzini > CC: Stefan Hajnoczi > --- > vl.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWvKyBAAoJEJykq7OBq3PIsnEH/jjy4gx6Q6hqHDx1f9mkvgcV SoK3QdvhjwbyYzIkSZEB+M4F4hIi/FxlTE/nftpwi7zE+e95xeJxiJD0igI+nzsQ lDmPsjQNzF2TNyLtsC0Dz7+ITA/oBEX5bONtogcWBY+TumFB2PlZ296YEm3CbHpt Wz8HeSl+5ScL6CoPqLGvVhrDS7J4UKC3fPga/GUFclefgU/Ok7rJzM3/q6oMysvd ZocPKbYL1kciclYrqbZ6g/8aUS3FaQC/CwSFCvUa+rL2It/uhYPNwpJ4NOxOGiTl zOhwFHheJCK+pTxXrBA4Yivm8jI+OnZJ3tzZ+9IVo8HpDORLU2ZUM3qMnK9HjDA= =px1b -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N--