From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTvma-0002R1-U8 for qemu-devel@nongnu.org; Thu, 11 Feb 2016 13:16:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTvmV-00043x-Np for qemu-devel@nongnu.org; Thu, 11 Feb 2016 13:16:00 -0500 Received: from domu-toccata.ens-lyon.fr ([140.77.166.138]:36077 helo=sonata.ens-lyon.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTvmV-000439-GD for qemu-devel@nongnu.org; Thu, 11 Feb 2016 13:15:55 -0500 Date: Thu, 11 Feb 2016 19:15:51 +0100 From: Samuel Thibault Message-ID: <20160211181551.GA2859@var.home> References: <02ab9a89d11c545664eefed50144e644a3d945cc.1454927009.git.samuel.thibault@ens-lyon.org> <56BAF7DC.1020904@redhat.com> <20160210092017.GB3423@var.bordeaux.inria.fr> <56BCCB4E.3040706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56BCCB4E.3040706@redhat.com> Subject: Re: [Qemu-devel] [PATCHv7 6/9] slirp: Reindent after refactoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Thomas Huth , zhanghailiang , Li Zhijian , Stefan Hajnoczi , Jason Wang , qemu-devel@nongnu.org, Vasiliy Tolstov , Dave Gilbert , Gonglei , Jan Kiszka , Huangpeng , Guillaume Subiron Eric Blake, on Thu 11 Feb 2016 10:56:30 -0700, wrote: > On 02/10/2016 02:20 AM, Samuel Thibault wrote: > > Thomas Huth, on Wed 10 Feb 2016 09:42:04 +0100, wrote: > >> On 08.02.2016 11:28, Samuel Thibault wrote: > >>> Signed-off-by: Guillaume Subiron > >>> Signed-off-by: Samuel Thibault > >>> --- > >>> slirp/tcp_input.c | 99 +++++++++++++++++++++++++++--------------------------- > >>> slirp/tcp_output.c | 29 ++++++++-------- > >>> slirp/tcp_subr.c | 50 +++++++++++++-------------- > >>> 3 files changed, 89 insertions(+), 89 deletions(-) > >> > >> Not sure, it's just an idea, but maybe it would even make sense to > >> re-indent the whole files in the QEMU coding style now? I mean, indent > >> with 4 spaces instead of tabs? > > > > I'm fine with doing it. Maintainers, what do you think? > > If done as part of the series, it's probably okay to do it as a > pre-requisite patch. Well, it'd rather be a post-requisite, since the patch series needs to reindent the files quite a bit (see above: almost two hundred lines reindented. > Don't mix it in with actual code changes, Sure. > and we don't do whole-sale reindenting except as part of a larger > series (because 'git blame' will point to whoever did the reindenting > instead of the original code, which doesn't make sense when > reindenting is done in isolation). Yep, I agree, that's why I prefer to ask. I'm here putting the number of lines reindented by my patch vs the total number of lines. A complete reindent would probably need to modify basically all lines of the files. slirp/tcp_input.c 99/1496 slirp/tcp_output.c 29/493 slirp/tcp_subr.c 50/926 It seems quite small in the end, perhaps we shouldn't reindent everything actually. Samuel