From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751103AbcBKW6l (ORCPT ); Thu, 11 Feb 2016 17:58:41 -0500 Received: from mail.kernel.org ([198.145.29.136]:58000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbcBKW6k (ORCPT ); Thu, 11 Feb 2016 17:58:40 -0500 Date: Thu, 11 Feb 2016 19:20:03 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar Subject: Re: [PATCH] perf python scripting: Append examples to err msg about audit-libs-python Message-ID: <20160211222003.GJ32168@kernel.org> References: <1455018790-13425-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455018790-13425-1-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Feb 09, 2016 at 08:53:10PM +0900, Taeung Song escreveu: > To print the syscall name, the audit-libs-python package > should be required. If not installed, print > the erron string e.g. After fixing spelling mistakes, applied, thanks, - Arnaldo > > # perf script syscall-counts > Install the audit-libs-python package to get syscall names. > > But the package name is different in Ubuntu > so append examples the erron string like below. > (similar to a error message of util/trace-event-scripting.c) > > # perf script syscall-counts > Install the audit-libs-python package to get syscall names. > For example: > # apt-get install python-audit (Ubuntu) > # yum install audit-libs-python (Fedora) > etc. > > Signed-off-by: Taeung Song > --- > tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py > index 15c8400..1d95009 100644 > --- a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py > +++ b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py > @@ -71,7 +71,10 @@ try: > except: > if not audit_package_warned: > audit_package_warned = True > - print "Install the audit-libs-python package to get syscall names" > + print "Install the audit-libs-python package to get syscall names.\n" \ > + "For example:\n # apt-get install python-audit (Ubuntu)" \ > + "\n # yum install audit-libs-python (Fedora)" \ > + "\n etc.\n" > > def syscall_name(id): > try: > -- > 2.5.0