From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752690AbcBLNw5 (ORCPT ); Fri, 12 Feb 2016 08:52:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47658 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424AbcBLNw4 (ORCPT ); Fri, 12 Feb 2016 08:52:56 -0500 Date: Fri, 12 Feb 2016 14:52:45 +0100 From: Jiri Olsa To: Wang Nan Cc: Alexei Starovoitov , Arnaldo Carvalho de Melo , Arnaldo Carvalho de Melo , Brendan Gregg , Adrian Hunter , Cody P Schafer , "David S. Miller" , He Kuang , =?iso-8859-1?Q?J=E9r=E9mie?= Galarneau , Jiri Olsa , Kirill Smelkov , Li Zefan , Masami Hiramatsu , Namhyung Kim , Peter Zijlstra , pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/54] perf tools: Enable config raw and numeric events Message-ID: <20160212135245.GE16190@krava.redhat.com> References: <1454680939-24963-1-git-send-email-wangnan0@huawei.com> <1454680939-24963-13-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454680939-24963-13-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2016 at 02:01:37PM +0000, Wang Nan wrote: > This patch allows setting config terms for raw and numeric events. > For example: > > # perf stat -e cycles/name=cyc/ ls > ... > 1821108 cyc > ... > > # perf stat -e r6530160/name=event/ ls > ... > 1103195 event > ... > > # perf record -e cycles -e 4:0x6530160/name=evtx,call-graph=fp/ -a sleep 1 > ... > # perf report --stdio > ... > # Samples: 124 of event 'cycles' > 46.61% 0.00% swapper [kernel.vmlinux] [k] cpu_startup_entry > 41.26% 0.00% swapper [kernel.vmlinux] [k] start_secondary > ... > # Samples: 91 of event 'evtx' > ... > 93.76% 0.00% swapper [kernel.vmlinux] [k] cpu_startup_entry > | > ---cpu_startup_entry > | > |--66.63%--call_cpuidle > | cpuidle_enter > | | got compile error: [jolsa@krava perf]$ make JOBS=1 BUILD: Doing 'make -j1' parallel build BISON util/parse-events-bison.c util/parse-events.y:436.23-38: error: symbol opt_event_config is used, but is not defined as a token and has no rules PE_VALUE ':' PE_VALUE opt_event_config ^^^^^^^^^^^^^^^^ util/parse-events.y:442.68-69: error: $4 of ‘event_legacy_numeric’ has no declared type ABORT_ON(parse_events_add_numeric(data, list, (u32)$1, $3, $4)); ^^ util/parse-events.y:443.34-35: error: $4 of ‘event_legacy_numeric’ has no declared type parse_events__free_terms($4); ^^ util/parse-events.y:454.74-75: error: $2 of ‘event_legacy_raw’ has no declared type ABORT_ON(parse_events_add_numeric(data, list, PERF_TYPE_RAW, $1, $2)); ^^ util/parse-events.y:455.34-35: error: $2 of ‘event_legacy_raw’ has no declared type parse_events__free_terms($2); ^^ util/Build:122: recipe for target 'util/parse-events-bison.c' failed make[3]: *** [util/parse-events-bison.c] Error 1 /home/jolsa/kernel/linux-perf/tools/build/Makefile.build:116: recipe for target 'util' failed make[2]: *** [util] Error 2 Makefile.perf:434: recipe for target 'libperf-in.o' failed make[1]: *** [libperf-in.o] Error 2 Makefile:68: recipe for target 'all' failed make: *** [all] Error 2 jirka