From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbcBLTfx (ORCPT ); Fri, 12 Feb 2016 14:35:53 -0500 Received: from smtprelay0120.hostedemail.com ([216.40.44.120]:43930 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750886AbcBLTfw (ORCPT ); Fri, 12 Feb 2016 14:35:52 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3871:3873:3874:4250:4362:5007:6261:7875:7904:10004:10400:10848:10967:11026:11232:11473:11658:11914:12517:12519:12555:12740:13069:13311:13357:14659:21060:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: wax27_6cf65a862164a X-Filterd-Recvd-Size: 1936 Date: Fri, 12 Feb 2016 14:35:47 -0500 From: Steven Rostedt To: Yang Shi Cc: aryabinin@virtuozzo.com, mingo@redhat.com, linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH] trace, kasan: silence Kasan warning in check_stack Message-ID: <20160212143547.703d9e9f@gandalf.local.home> In-Reply-To: <1454956782-5944-1-git-send-email-yang.shi@linaro.org> References: <1454956782-5944-1-git-send-email-yang.shi@linaro.org> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Feb 2016 10:39:42 -0800 Yang Shi wrote: > > Signed-off-by: Yang Shi > --- > kernel/trace/trace_stack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c > index 202df6c..61e5e1e 100644 > --- a/kernel/trace/trace_stack.c > +++ b/kernel/trace/trace_stack.c > @@ -156,7 +156,7 @@ check_stack(unsigned long ip, unsigned long *stack) > for (; p < top && i < stack_trace_max.nr_entries; p++) { > if (stack_dump_trace[i] == ULONG_MAX) > break; > - if (*p == stack_dump_trace[i]) { Can you add a comment explaining this. Something like: /* * The READ_ONCE_NOCHECK() is used to let KASAN know that * this is not an stack-out-of-bounds error. */ Thanks, -- Steve > + if ((READ_ONCE_NOCHECK(*p)) == stack_dump_trace[i]) { > stack_dump_trace[x] = stack_dump_trace[i++]; > this_size = stack_trace_index[x++] = > (top - p) * sizeof(unsigned long);