From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416AbcBMLIv (ORCPT ); Sat, 13 Feb 2016 06:08:51 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:48318 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbcBMLIs (ORCPT ); Sat, 13 Feb 2016 06:08:48 -0500 Date: Sat, 13 Feb 2016 06:08:44 -0500 (EST) Message-Id: <20160213.060844.528410343007511546.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, andrew@lunn.ch, kevin.smith@elecsyscorp.com Subject: Re: [PATCH net] net: dsa: mv88e6xxx: do not leave reserved VLANs From: David Miller In-Reply-To: <1454699234-6157-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1454699234-6157-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 13 Feb 2016 03:08:47 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot Date: Fri, 5 Feb 2016 14:07:14 -0500 > BRIDGE_VLAN_FILTERING automatically adds a newly bridged port to the > VLAN with the bridge's default_pvid. > > The mv88e6xxx driver currently reserves VLANs 4000+ for unbridged ports > isolation. When a port joins a bridge, it leaves its reserved VLAN. When > a port leaves a bridge, it joins again its reserved VLAN. > > But if the VLAN filtering is disabled, or if this hardware VLAN is > already in use, the bridged port ends up with no default VLAN, and the > communication with the CPU is thus broken. > > To fix this, make a port join its reserved VLAN once on setup, never > leave it, and restore its PVID after another one was eventually used. > > Signed-off-by: Vivien Didelot Applied.