From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915/BXT: Fixed COS blanking issue Date: Mon, 15 Feb 2016 17:28:01 +0100 Message-ID: <20160215162801.GQ11240@phenom.ffwll.local> References: <1454435657-29027-1-git-send-email-ramalingam.c@intel.com> <8737ta2knw.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 75A896E194 for ; Mon, 15 Feb 2016 16:27:36 +0000 (UTC) Received: by mail-wm0-f49.google.com with SMTP id a4so63290937wme.1 for ; Mon, 15 Feb 2016 08:27:36 -0800 (PST) Content-Disposition: inline In-Reply-To: <8737ta2knw.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBGZWIgMDMsIDIwMTYgYXQgMTE6NDQ6MDNBTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAwMiBGZWIgMjAxNiwgUmFtYWxpbmdhbSBDIDxyYW1hbGluZ2FtLmNAaW50 ZWwuY29tPiB3cm90ZToKPiA+IEZyb206IFVtYSBTaGFua2FyIDx1bWEuc2hhbmthckBpbnRlbC5j b20+Cj4gPgo+ID4gRHVyaW5nIENoYXJnaW5nIE9TIG1vZGUsIG1pcGkgZGlzcGxheSB3YXMgYmxh bmtpbmcuVGhpcyBpcwo+ID4gYmVjYXVzZSBkdXJpbmcgZHJpdmVyIGxvYWQsIHRob3VnaCBlbmNv ZGVyLCBjb25uZWN0b3Igd2VyZQo+ID4gYWN0aXZlIGJ1dCBjcnRjIHJldHVybmVkIGluYWN0aXZl LiBUaGlzIGNhdXNlZCBzYW5pdGl6ZQo+ID4gZnVuY3Rpb24gdG8gZGlzYWJsZSB0aGUgRFNJIHBh bmVsLiBJbiBBT1MsIHRoaXMgaXMgZmluZQo+ID4gc2luY2UgSFdDIHdpbGwgZG8gYSBtb2Rlc2V0 IGFuZCBjcnRjLCBjb25uZWN0b3IsIGVuY29kZXIKPiA+IG1hcHBpbmcgd2lsbCBiZSByZXN0b3Jl ZC4gQnV0IGluIENPUywgbm8gbW9kZXNldCBpcyBjYWxsZWQsCj4gPiBpdCBqdXN0IGNhbGxzIERQ TVMgT04vT0ZGLgo+ID4KPiA+IFRoaXMgaXMgZmluZSBvbiBCWVQvQ0hUIHNpbmNlIHRyYW5zY29k ZXIgaXMgY29tbW9uIGIvdwo+ID4gYWxsIGVuY29kZXJzLiBCdXQgZm9yIEJYVCwgdGhlcmUgaXMg YSBzZXBhcmF0ZSBtaXBpCj4gPiB0cmFuc2NvZGVyLiBIZW5jZSB0aGlzIG5lZWRzIHNwZWNpYWwg aGFuZGxpbmcgZm9yIEJYVC4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBVbWEgU2hhbmthciA8dW1h LnNoYW5rYXJAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogUmFtYWxpbmdhbSBDIDxyYW1h bGluZ2FtLmNAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jIHwgIDEwNyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDEwMSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+ID4K PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IGE2NjIyMGEuLmY4 Njg1ZjUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gQEAg LTc4MTQsNiArNzgxNCw2OSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zZXRfcGlwZV90aW1pbmdzKHN0 cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjKQo+ID4gIAkJICAgKGludGVsX2NydGMtPmNvbmZp Zy0+cGlwZV9zcmNfaCAtIDEpKTsKPiA+ICB9Cj4gPiAgCj4gPiArc3RhdGljIHZvaWQgaW50ZWxf Z2V0X2RzaV9waXBlX3RpbWluZ3Moc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gPiArCQkJCSAg IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiA+ICt7Cj4gPiArCXN0cnVj dCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiA+ICsJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+ICsJZW51bSB0cmFuc2Nv ZGVyIGNwdV90cmFuc2NvZGVyID0gcGlwZV9jb25maWctPmNwdV90cmFuc2NvZGVyOwo+ID4gKwlz dHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcjsKPiA+ICsJdWludDMyX3QgdG1wOwo+ID4gKwo+ ID4gKwl0bXAgPSBJOTE1X1JFQUQoSFRPVEFMKGNwdV90cmFuc2NvZGVyKSk7Cj4gPiArCXBpcGVf Y29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19oZGlzcGxheSA9ICh0bXAgJiAweGZmZmYp ICsgMTsKPiA+ICsJcGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2h0b3RhbCA9 Cj4gPiArCQkJCQkJKCh0bXAgPj4gMTYpICYgMHhmZmZmKSArIDE7Cj4gPiArCXRtcCA9IEk5MTVf UkVBRChIQkxBTksoY3B1X3RyYW5zY29kZXIpKTsKPiA+ICsJcGlwZV9jb25maWctPmJhc2UuYWRq dXN0ZWRfbW9kZS5jcnRjX2hibGFua19zdGFydCA9ICh0bXAgJiAweGZmZmYpICsgMTsKPiA+ICsJ cGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2hibGFua19lbmQgPQo+ID4gKwkJ CQkJCSgodG1wID4+IDE2KSAmIDB4ZmZmZikgKyAxOwo+ID4gKwl0bXAgPSBJOTE1X1JFQUQoSFNZ TkMoY3B1X3RyYW5zY29kZXIpKTsKPiA+ICsJcGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9k ZS5jcnRjX2hzeW5jX3N0YXJ0ID0gKHRtcCAmIDB4ZmZmZikgKyAxOwo+ID4gKwlwaXBlX2NvbmZp Zy0+YmFzZS5hZGp1c3RlZF9tb2RlLmNydGNfaHN5bmNfZW5kID0KPiA+ICsJCQkJCQkoKHRtcCA+ PiAxNikgJiAweGZmZmYpICsgMTsKPiA+ICsKPiA+ICsJdG1wID0gSTkxNV9SRUFEKFZCTEFOSyhj cHVfdHJhbnNjb2RlcikpOwo+ID4gKwlwaXBlX2NvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlLmNy dGNfdmJsYW5rX3N0YXJ0ID0gKHRtcCAmIDB4ZmZmZikgKyAxOwo+ID4gKwlwaXBlX2NvbmZpZy0+ YmFzZS5hZGp1c3RlZF9tb2RlLmNydGNfdmJsYW5rX2VuZCA9Cj4gPiArCQkJCQkJKCh0bXAgPj4g MTYpICYgMHhmZmZmKSArIDE7Cj4gPiArCXRtcCA9IEk5MTVfUkVBRChWU1lOQyhjcHVfdHJhbnNj b2RlcikpOwo+ID4gKwlwaXBlX2NvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlLmNydGNfdnN5bmNf c3RhcnQgPSAodG1wICYgMHhmZmZmKSArIDE7Cj4gPiArCXBpcGVfY29uZmlnLT5iYXNlLmFkanVz dGVkX21vZGUuY3J0Y192c3luY19lbmQgPQo+ID4gKwkJCQkJCSgodG1wID4+IDE2KSAmIDB4ZmZm ZikgKyAxOwo+ID4gKwo+ID4gKwlpZiAoSTkxNV9SRUFEKFBJUEVDT05GKGNwdV90cmFuc2NvZGVy KSkgJiBQSVBFQ09ORl9JTlRFUkxBQ0VfTUFTSykgewo+ID4gKwkJcGlwZV9jb25maWctPmJhc2Uu YWRqdXN0ZWRfbW9kZS5mbGFncyB8PQo+ID4gKwkJCQkJCURSTV9NT0RFX0ZMQUdfSU5URVJMQUNF Owo+ID4gKwkJcGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX3Z0b3RhbCArPSAx Owo+ID4gKwkJcGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX3ZibGFua19lbmQg Kz0gMTsKPiA+ICsJfQo+ID4gKwo+ID4gKwo+ID4gKwlmb3JfZWFjaF9lbmNvZGVyX29uX2NydGMo ZGV2LCAmY3J0Yy0+YmFzZSwgZW5jb2Rlcikgewo+ID4gKwkJc3RydWN0IGludGVsX2RzaSAqaW50 ZWxfZHNpID0KPiA+ICsJCQllbmNfdG9faW50ZWxfZHNpKCZlbmNvZGVyLT5iYXNlKTsKPiA+ICsJ CWVudW0gcG9ydCBwb3J0Owo+ID4gKwo+ID4gKwkJcGlwZV9jb25maWctPnBpcGVfYnBwID0gaW50 ZWxfZHNpLT5kc2lfYnBwOwo+ID4gKwkJZm9yX2VhY2hfZHNpX3BvcnQocG9ydCwgaW50ZWxfZHNp LT5wb3J0cykgewo+ID4gKwkJCXBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19o ZGlzcGxheSA9Cj4gPiArCQkJCUk5MTVfUkVBRChCWFRfTUlQSV9UUkFOU19IQUNUSVZFKHBvcnQp KTsKPiA+ICsJCQlwaXBlX2NvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlLmNydGNfdmRpc3BsYXkg PQo+ID4gKwkJCQlJOTE1X1JFQUQoQlhUX01JUElfVFJBTlNfVkFDVElWRShwb3J0KSk7Cj4gPiAr CQkJcGlwZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX3Z0b3RhbCA9Cj4gPiArCQkJ CUk5MTVfUkVBRChCWFRfTUlQSV9UUkFOU19WVE9UQUwocG9ydCkpOwo+ID4gKwkJfQo+ID4gKwl9 Cj4gPiArCj4gPiArCXRtcCA9IEk5MTVfUkVBRChQSVBFU1JDKGNydGMtPnBpcGUpKTsKPiA+ICsJ cGlwZV9jb25maWctPnBpcGVfc3JjX2ggPSAodG1wICYgMHhmZmZmKSArIDE7Cj4gPiArCXBpcGVf Y29uZmlnLT5waXBlX3NyY193ID0gKCh0bXAgPj4gMTYpICYgMHhmZmZmKSArIDE7Cj4gPiArCj4g PiArCXBpcGVfY29uZmlnLT5iYXNlLm1vZGUudmRpc3BsYXkgPSBwaXBlX2NvbmZpZy0+cGlwZV9z cmNfaDsKPiA+ICsJcGlwZV9jb25maWctPmJhc2UubW9kZS5oZGlzcGxheSA9IHBpcGVfY29uZmln LT5waXBlX3NyY193Owo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMgdm9pZCBpbnRlbF9nZXRfcGlw ZV90aW1pbmdzKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ID4gIAkJCQkgICBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gPiAgewo+ID4gQEAgLTk5NjksNiArMTAwMzIs NyBAQCBzdGF0aWMgYm9vbCBoYXN3ZWxsX2dldF9waXBlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfY3J0 YyAqY3J0YywKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5k ZXZfcHJpdmF0ZTsKPiA+ICAJZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2RvbWFpbiBwZml0X2Rv bWFpbjsKPiA+ICAJdWludDMyX3QgdG1wOwo+ID4gKwlib29sIGlzX2RzaSA9IGZhbHNlOwo+ID4g IAo+ID4gIAlpZiAoIWludGVsX2Rpc3BsYXlfcG93ZXJfaXNfZW5hYmxlZChkZXZfcHJpdiwKPiA+ ICAJCQkJCSBQT1dFUl9ET01BSU5fUElQRShjcnRjLT5waXBlKSkpCj4gPiBAQCAtOTk5OSwxNyAr MTAwNjMsNDggQEAgc3RhdGljIGJvb2wgaGFzd2VsbF9nZXRfcGlwZV9jb25maWcoc3RydWN0IGlu dGVsX2NydGMgKmNydGMsCj4gPiAgCQkJcGlwZV9jb25maWctPmNwdV90cmFuc2NvZGVyID0gVFJB TlNDT0RFUl9FRFA7Cj4gPiAgCX0KPiA+ICAKPiA+ICsJaWYgKGRldl9wcml2LT52YnQuaGFzX21p cGkpIHsKPiA+ICsJCWVudW0gcG9ydCBwb3J0X251bSA9IChkZXZfcHJpdi0+dmJ0LmRzaS5wb3J0 ID09IERWT19QT1JUX01JUElBKQo+ID4gKwkJCQkJPyBQT1JUX0EgOiBQT1JUX0M7Cj4gCj4gSnVz dCAiZW51bSBwb3J0IHBvcnQiIHBsZWFzZS4KPiAKPiA+ICsJCXVpbnQzMl90IGRzaV9jdHJsID0g STkxNV9SRUFEKE1JUElfQ1RSTChwb3J0X251bSkpOwo+ID4gKwo+ID4gKwkJdG1wID0gSTkxNV9S RUFEKEJYVF9NSVBJX1BPUlRfQ1RSTChwb3J0X251bSkpOwo+ID4gKwkJaWYgKHRtcCAmIERQSV9F TkFCTEUpIHsKPiA+ICsJCQllbnVtIHBpcGUgdHJhbnNfZHNpX3BpcGU7Cj4gPiArCj4gPiArCQkJ c3dpdGNoIChkc2lfY3RybCAmIEJYVF9QSVBFX1NFTEVDVF9NQVNLKSB7Cj4gPiArCQkJZGVmYXVs dDoKPiA+ICsJCQkJV0FSTigxLCAidW5rbm93biBwaXBlIGxpbmtlZCB0byBkc2kgdHJhbnNjb2Rl clxuIik7Cj4gPiArCQkJCXJldHVybiBmYWxzZTsKPiA+ICsJCQljYXNlIEJYVF9QSVBFX1NFTEVD VF9BOgo+ID4gKwkJCQl0cmFuc19kc2lfcGlwZSA9IFBJUEVfQTsKPiA+ICsJCQkJYnJlYWs7Cj4g PiArCQkJY2FzZSBCWFRfUElQRV9TRUxFQ1RfQjoKPiA+ICsJCQkJdHJhbnNfZHNpX3BpcGUgPSBQ SVBFX0I7Cj4gPiArCQkJCWJyZWFrOwo+ID4gKwkJCWNhc2UgQlhUX1BJUEVfU0VMRUNUX0M6Cj4g PiArCQkJCXRyYW5zX2RzaV9waXBlID0gUElQRV9DOwo+ID4gKwkJCQlicmVhazsKPiA+ICsJCQl9 Cj4gPiArCj4gPiArCQkJaWYgKHRyYW5zX2RzaV9waXBlID09IGNydGMtPnBpcGUpCj4gPiArCQkJ CWlzX2RzaSA9IHRydWU7Cj4gPiArCQl9Cj4gPiArCX0KPiA+ICsKPiAKPiBZb3UgbmVlZCB0byBz ZXQgcGlwZV9jb25maWctPmhhc19kc2lfZW5jb2Rlci4KPiAKPiBUaGlzIGlzIHBvc3NpYmx5IGNs ZWFuZXN0LCBpZiB5b3UgYWJzdHJhY3QgdGhlIGFib3ZlIGludG8gYSBzZXBhcmF0ZQo+IGZ1bmN0 aW9uLCBzYXkKPiAKPiBieHRfZ2V0X3BpcGVfY29uZmlnX2RzaShzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0Yywgc3RydWN0IGludGVsX2NydGNfc3RhdGUKPiAqcGlwZV9jb25maWcpCj4gCj4gYW5kIHNl dCBwaXBlX2NvbmZpZy0+aGFzX2RzaV9lbmNvZGVyIGlmIHRyYW5zX2RzaV9waXBlID09IGNydGMt PnBpcGUuCj4gCj4gVGhpcyBwcm9iYWJseSBuZWVkcyB0byB0YWtlIGludG8gYWNjb3VudCB0aGUg ZGlmZmVyZW50IHBvd2VyIGRvbWFpbnMgYXMKPiB3ZWxsPwo+IAo+IEJSLAo+IEphbmkuCj4gCj4g Cj4gUFMuIEkgZ3Vlc3Mgd2UncmUgbWlzc2luZyB0aGUgaGFzX2RzaV9lbmNvZGVyIHJlYWRvdXQg Zm9yIEJZVC9DSFYgYXMKPiB3ZWxsLiA6KAoKVGhhdCBtZWFucyB3ZSByZWFsbHksIHJlYWxseSBz aG91bGQgaGF2ZSBhIHBpcGUgY29uZmlnIGNoZWNrIGZvcgpoYXNfZHNpX2VuY29kZXIsIHdoaWNo IHdlJ3JlIGxhY2tpbmcgdG9vLiBQbHVzIHdlIGRvbid0IGV2ZW4gaGF2ZSBhCm1hY2hpbmUgd2l0 aCBEU0kgaW4gQ0ksIHdoaWNoIGlzIHdoeSBubyBvbmUgbm90aWNlZCB0aGF0IGVpdGhlci4KClBs ZWFzZSBhZGQgYWxsIHRoZSBtaXNzaW5nIGJpdHMgaGVyZS4gSXJvbiBydWxlIGlzIHRoYXQgaWYg eW91IHJlYWQgb3V0CnNvbWUgaHcgc3RhdGUsIHRoZW4geW91IF9tdXN0XyBhZGQgY29ycmVzcG9u ZGluZyBzdGF0ZSBjaGVja3Mgb3QKaW50ZWxfcGlwZV9jb25maWdfY29tcGFyZS4KLURhbmllbAot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==