From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753153AbcBOWe3 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Feb 2016 17:34:29 -0500
Received: from mail.pqgruber.com ([178.189.19.235]:58786 "EHLO
	mail.pqgruber.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752548AbcBOWe1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Feb 2016 17:34:27 -0500
Date: Mon, 15 Feb 2016 23:34:24 +0100
From: Clemens Gruber <clemens.gruber@pqgruber.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2] phy: marvell: Fix and unify reg-init behavior
Message-ID: <20160215223423.GA836@archie.tuxnet.lan>
References: <1455566460-31291-1-git-send-email-clemens.gruber@pqgruber.com>
 <CAOMZO5AO4KY+PcQ7ka5Ot-TL222frLO50On+tFXFWGkKhQ25PA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOMZO5AO4KY+PcQ7ka5Ot-TL222frLO50On+tFXFWGkKhQ25PA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Fabio,

On Mon, Feb 15, 2016 at 06:54:29PM -0200, Fabio Estevam wrote:
> On Mon, Feb 15, 2016 at 6:01 PM, Clemens Gruber
> <clemens.gruber@pqgruber.com> wrote:
> 
> > +static int marvell_config_init(struct phy_device *phydev)
> > +{
> > +       int err;
> > +
> > +       /* Set registers from marvell,reg-init DT property */
> > +       err = marvell_of_reg_init(phydev);
> > +       if (err < 0)
> > +               return err;
> > +
> > +       return 0;
> >  }
> 
> Couldn't this be replaced by
> 
> return marvell_of_reg_init(phydev); ?

I wanted to add some missing errata fixes from the Marvell Release Notes
into that function (in the near future).
But you are right, I should probably not change things preemptively.

I'll send a v3 with that part replaced!

Thanks,
Clemens