From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1aVZbQ-0007GV-U5
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 01:59:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1aVZbN-0003WD-OR
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 01:59:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48287)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1aVZbN-0003W7-J0
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 01:59:13 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id 01BD25A4C
	for <qemu-devel@nongnu.org>; Tue, 16 Feb 2016 06:59:12 +0000 (UTC)
Date: Tue, 16 Feb 2016 14:58:59 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160216065859.GF7978@pxdev.xzpeter.org>
References: <1449628943-10197-1-git-send-email-peterx@redhat.com>
	<1449628943-10197-10-git-send-email-peterx@redhat.com>
	<20160216064059.GF18664@ad.usersys.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160216064059.GF18664@ad.usersys.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 09/11] Dump: add qmp command "query-dump"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com

On Tue, Feb 16, 2016 at 02:40:59PM +0800, Fam Zheng wrote:
> On Wed, 12/09 10:42, Peter Xu wrote:
> > -    s->status = (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED);
> > -    error_propagate(errp, local_err);
> 
> This means the error is released by caller, ...
> 
> > +    /* make sure status is written after written_size updates */
> > +    smp_wmb();
> > +    atomic_set(&s->status,
> > +               (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED));
> 
> but it is removed now.  Is local_err leaked now?

Right. Lost it during switching of patches and merges. Will
fix. Thanks!

Peter