All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com,
	qemu-devel@nongnu.org, pbonzini@redhat.com,
	lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 10/11] Dump: add hmp command "info dump"
Date: Tue, 16 Feb 2016 15:18:03 +0800	[thread overview]
Message-ID: <20160216071803.GG7978@pxdev.xzpeter.org> (raw)
In-Reply-To: <20160216064615.GG18664@ad.usersys.redhat.com>

On Tue, Feb 16, 2016 at 02:46:15PM +0800, Fam Zheng wrote:
> On Wed, 12/09 10:42, Peter Xu wrote:
> > +
> > +void hmp_info_dump(Monitor *mon, const QDict *qdict)
> > +{
> > +    DumpQueryResult *result = qmp_query_dump(NULL);
> 
> If something goes wrong, it is probably better to pass in local_err to
> qmp_query_dump and print the error info instead of assuming result's fields are
> all valid and trying to interpret them.
> 
> Fam

This is because qmp_query_dump() will never fail, and it's not using
errp. Will assert "result" too before use.

Thanks.
Peter

  reply	other threads:[~2016-02-16  7:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09  2:42 [Qemu-devel] [PATCH v6 00/11] Add basic "detach" support for dump-guest-memory Peter Xu
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}() Peter Xu
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 02/11] dump-guest-memory: add "detach" flag for QMP/HMP interfaces Peter Xu
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 03/11] dump-guest-memory: using static DumpState, add DumpStatus Peter Xu
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 04/11] dump-guest-memory: add dump_in_progress() helper function Peter Xu
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 05/11] dump-guest-memory: introduce dump_process() " Peter Xu
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 06/11] dump-guest-memory: disable dump when in INMIGRATE state Peter Xu
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 07/11] dump-guest-memory: add "detach" support Peter Xu
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 08/11] DumpState: adding total_size and written_size fields Peter Xu
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 09/11] Dump: add qmp command "query-dump" Peter Xu
2016-02-16  6:40   ` Fam Zheng
2016-02-16  6:58     ` Peter Xu
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 10/11] Dump: add hmp command "info dump" Peter Xu
2016-02-16  6:46   ` Fam Zheng
2016-02-16  7:18     ` Peter Xu [this message]
2015-12-09  2:42 ` [Qemu-devel] [PATCH v6 11/11] dump-guest-memory: add qmp event DUMP_COMPLETED Peter Xu
2016-02-16  6:50   ` Fam Zheng
2016-02-16  2:31 ` [Qemu-devel] [PATCH v6 00/11] Add basic "detach" support for dump-guest-memory Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160216071803.GG7978@pxdev.xzpeter.org \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=drjones@redhat.com \
    --cc=famz@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lersek@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.