All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Mathias Nyman <mathias.nyman@intel.com>
Subject: Re: [PATCH] pinctrl: intel: Turn Baytrail support to tristate
Date: Tue, 16 Feb 2016 12:34:35 +0200	[thread overview]
Message-ID: <20160216103435.GG1742@lahna.fi.intel.com> (raw)
In-Reply-To: <20160216112555.79aa1837@endymion>

On Tue, Feb 16, 2016 at 11:25:55AM +0100, Jean Delvare wrote:
> Can you describe the respective roles of acpi_lpss and pinctrl-baytrail
> in this process? Both reference ACPI devices "INT33B2" and "INT33FC".
> Who instantiates these devices? Who pulls GPIO 12 low? Who detects when
> this happens? Who triggers the event that leads to _L12 being executed?

acpi_lpss enumerates the ACPI devices and creates platform devices from
them. pinctrl-baytrail binds to the platform device.

Hardware pulls down the GPIO 12. For example when the power adapter is
connected. This is detected by the GPIO hardware and the driver
(pinctrl-baytrail) that then executes the method (based on the code in
gpiolib-acpi.c::acpi_gpiochip_request_interrupt()).

> > I'm not opposing turning this driver to a module. If it breaks things we
> > can always revert the patch ;-)
> 
> ... or try to solve the problem cleanly, if that is possible.

Sure.

      reply	other threads:[~2016-02-16 10:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 11:05 [PATCH] pinctrl: intel: Turn Baytrail support to tristate Jean Delvare
2016-02-11 11:23 ` Mika Westerberg
2016-02-15 23:13   ` Linus Walleij
2016-02-16  8:53     ` Mika Westerberg
2016-02-16  9:15       ` Jean Delvare
2016-02-16  9:49         ` Mika Westerberg
2016-02-16 10:25           ` Jean Delvare
2016-02-16 10:34             ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160216103435.GG1742@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jdelvare@suse.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.