From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [kvm-unit-tests PATCH v4 11/17] powerpc/ppc64: add hcall support and putchar Date: Wed, 17 Feb 2016 13:04:25 +1100 Message-ID: <20160217020425.GD5239@voom.redhat.com> References: <1455544166-19766-1-git-send-email-drjones@redhat.com> <1455544166-19766-12-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AbQceqfdZEv+FvjW" Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, thuth@redhat.com, dgibson@redhat.com, agraf@suse.de, lvivier@redhat.com, pbonzini@redhat.com To: Andrew Jones Return-path: Received: from ozlabs.org ([103.22.144.67]:43974 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756624AbcBQGuY (ORCPT ); Wed, 17 Feb 2016 01:50:24 -0500 Content-Disposition: inline In-Reply-To: <1455544166-19766-12-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: --AbQceqfdZEv+FvjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 15, 2016 at 02:49:20PM +0100, Andrew Jones wrote: > Add broken sc1 detection and patching and an hcall for putchar, > to use in puts. That, along with a couple more lines in start to > prepare for C code, and a branch to main(), gets us "hello world". > Run with >=20 > qemu-system-ppc64 -M pseries \ > -bios powerpc/boot_rom.bin \ > -display none -serial stdio \ > -kernel powerpc/selftest.elf >=20 > (We're still not relocating yet, that comes in a later patch. Thus, > testing hello-world at this point requires a hacked QEMU and linking > the unit test at QEMU's kernel load address.) >=20 > Signed-off-by: Andrew Jones > Tested-by: Laurent Vivier > --- > lib/powerpc/asm/hcall.h | 46 ++++++++++++++++++++++++++++ > lib/powerpc/hcall.c | 79 +++++++++++++++++++++++++++++++++++++++++++= ++++++ > lib/powerpc/io.c | 15 ++++++++-- > lib/ppc64/asm/hcall.h | 1 + > powerpc/Makefile.common | 2 ++ > powerpc/cstart64.S | 21 +++++++++++++ > 6 files changed, 162 insertions(+), 2 deletions(-) > create mode 100644 lib/powerpc/asm/hcall.h > create mode 100644 lib/powerpc/hcall.c > create mode 100644 lib/ppc64/asm/hcall.h >=20 > diff --git a/lib/powerpc/asm/hcall.h b/lib/powerpc/asm/hcall.h > new file mode 100644 > index 0000000000000..f861287ac2083 > --- /dev/null > +++ b/lib/powerpc/asm/hcall.h > @@ -0,0 +1,46 @@ > +#ifndef _ASMPOWERPC_HCALL_H_ > +#define _ASMPOWERPC_HCALL_H_ > +/* > + * Copyright (C) 2016, Red Hat Inc, Andrew Jones > + * > + * This work is licensed under the terms of the GNU LGPL, version 2. > + */ > + > +#define SC1 0x44000022 > +#define SC1_REPLACEMENT 0x7c000268 > + > +#define H_SUCCESS 0 > +#define H_HARDWARE -1 > +#define H_FUNCTION -2 > +#define H_PRIVILEGE -3 > +#define H_PARAMETER -4 > + > +#define H_SET_DABR 0x28 > +#define H_PUT_TERM_CHAR 0x58 > + > +#ifndef __ASSEMBLY__ > +#include > + > +/* > + * hcall_have_broken_sc1 checks if we're on a host with a broken sc1. > + * Returns true if we are. > + */ > +extern bool hcall_have_broken_sc1(void); > + > +/* > + * hcall_patch_broken_sc1 patches hcall's sc1 instruction, if needed, > + * allowing all hypercalls built on it to work. > + */ > +extern void hcall_patch_broken_sc1(void); > + > +/* > + * hcall is the hypercall wrapper function. unittests may do what > + * they like, but the framework should make all hypercalls through > + * here to ensure they use a working sc1 instruction, and properly > + * handle clobbered registers. @nr is the hypercall number. > + */ > +extern unsigned long > +hcall(unsigned long nr, unsigned long *in, unsigned long *out); > + > +#endif /* !__ASSEMBLY__ */ > +#endif /* _ASMPOWERPC_HCALL_H_ */ > diff --git a/lib/powerpc/hcall.c b/lib/powerpc/hcall.c > new file mode 100644 > index 0000000000000..db99949352133 > --- /dev/null > +++ b/lib/powerpc/hcall.c > @@ -0,0 +1,79 @@ > +/* > + * Hypercall helpers > + * > + * broken_sc1 probing/patching inspired by SLOF, see > + * SLOF:lib/libhvcall/brokensc1.c > + * > + * hcall() implementation inspired by Linux's epapr_hypercall, see > + * arch/powerpc/include/asm/epapr_hcalls.h > + * > + * Copyright (C) 2016, Red Hat Inc, Andrew Jones > + * > + * This work is licensed under the terms of the GNU LGPL, version 2. > + */ > +#include > +#include > + > +static u32 sc1[]; > + > +bool hcall_have_broken_sc1(void) > +{ > + register unsigned long r3 asm("r3") =3D H_SET_DABR; > + register unsigned long r4 asm("r4") =3D 0; > + > + asm volatile("sc 1" > + : "=3Dr" (r3) > + : "r" (r3), "r" (r4) > + : "r5", "r6", "r7", "r8", "r9", "r10", "r11", "r12"); > + return r3 =3D=3D (unsigned long)H_PRIVILEGE; > +} > + > +void hcall_patch_broken_sc1(void) > +{ > + if (!hcall_have_broken_sc1()) > + return; > + sc1[0] =3D SC1_REPLACEMENT; > +} > + > +unsigned long hcall(unsigned long nr, unsigned long *in, unsigned long *= out) > +{ > + register unsigned long r3 asm("r3") =3D nr; > + register unsigned long r4 asm("r4") =3D in[0]; > + register unsigned long r5 asm("r5") =3D in[1]; > + register unsigned long r6 asm("r6") =3D in[2]; > + register unsigned long r7 asm("r7") =3D in[3]; > + register unsigned long r8 asm("r8") =3D in[4]; > + register unsigned long r9 asm("r9") =3D in[5]; > + register unsigned long r10 asm("r10") =3D in[6]; > + register unsigned long r11 asm("r11") =3D in[7]; > + > + asm volatile("bl sc1" > + : "=3Dr"(r3), "=3Dr"(r4), "=3Dr"(r5), "=3Dr"(r6), "=3Dr"(r7), > + "=3Dr"(r8), "=3Dr"(r9), "=3Dr"(r10), "=3Dr"(r11) > + : "r"(r3), "r"(r4), "r"(r5), "r"(r6), "r"(r7), > + "r"(r8), "r"(r9), "r"(r10), "r"(r11) > + : "r12", "memory", "lr"); > + > + out[0] =3D r4; > + out[1] =3D r5; > + out[2] =3D r6; > + out[3] =3D r7; > + out[4] =3D r8; > + out[5] =3D r9; > + out[6] =3D r10; > + out[7] =3D r11; > + > + return r3; I'm not sure there's much advantage to having this in C, rather than folding this and the sc1 symbol into a single asm implemented hcall function. Doing it that way might more easily allow you to avoid packing the arguments into an array, before unpacking them into registers again, which seems a bit perverse. > +} > + > +void putchar(int c) > +{ > + unsigned long in[8], out[8]; > + > + in[0] =3D 0; /* default vty */ > + in[1] =3D 1; /* just 1 byte */ > + in[2] =3D (unsigned long)c << 56; > + > + hcall(H_PUT_TERM_CHAR, in, out); > +} > diff --git a/lib/powerpc/io.c b/lib/powerpc/io.c > index 0af45742fc900..5e1fa8dd96ab6 100644 > --- a/lib/powerpc/io.c > +++ b/lib/powerpc/io.c > @@ -6,15 +6,26 @@ > * This work is licensed under the terms of the GNU LGPL, version 2. > */ > #include > +#include > + > +extern void halt(int code); > +extern void putchar(int c); > + > +static struct spinlock uart_lock; > =20 > void io_init(void) > { > } > =20 > -void puts(const char *s __unused) > +void puts(const char *s) > { > + spin_lock(&uart_lock); The name uart_lock isn't really accurate, since it's a hypervisor console rather than serial. > + while (*s) > + putchar(*s++); > + spin_unlock(&uart_lock); > } > =20 > -void exit(int code __unused) > +void exit(int code) > { > + halt(code); > } > diff --git a/lib/ppc64/asm/hcall.h b/lib/ppc64/asm/hcall.h > new file mode 100644 > index 0000000000000..daabaca510cd4 > --- /dev/null > +++ b/lib/ppc64/asm/hcall.h > @@ -0,0 +1 @@ > +#include "../../powerpc/asm/hcall.h" > diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common > index 0c3eaba0d3aab..89610b525f0c1 100644 > --- a/powerpc/Makefile.common > +++ b/powerpc/Makefile.common > @@ -21,6 +21,7 @@ CFLAGS +=3D -ffreestanding > CFLAGS +=3D -Wextra > CFLAGS +=3D -O2 > CFLAGS +=3D -I lib -I lib/libfdt > +CFLAGS +=3D -Wa,-mregnames > =20 > asm-offsets =3D lib/$(ARCH)/asm-offsets.h > include scripts/asm-offsets.mak > @@ -29,6 +30,7 @@ cflatobjs +=3D lib/util.o > cflatobjs +=3D lib/alloc.o > cflatobjs +=3D lib/devicetree.o > cflatobjs +=3D lib/powerpc/io.o > +cflatobjs +=3D lib/powerpc/hcall.o > =20 > libgcc :=3D $(shell $(CC) $(machine) --print-libgcc-file-name) > start_addr :=3D $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offse= t) ))) > diff --git a/powerpc/cstart64.S b/powerpc/cstart64.S > index f90828dee1c19..623fd693b02d1 100644 > --- a/powerpc/cstart64.S > +++ b/powerpc/cstart64.S > @@ -7,13 +7,34 @@ > */ > #define __ASSEMBLY__ > =20 > +#define LOAD_REG_IMMEDIATE(reg,expr) \ > + lis reg,(expr)@highest; \ > + ori reg,reg,(expr)@higher; \ > + rldicr reg,reg,32,31; \ > + oris reg,reg,(expr)@h; \ > + ori reg,reg,(expr)@l; > + > +#define LOAD_REG_ADDR(reg,name) \ > + ld reg,name@got(r2) > + > .section .init > =20 > .globl start > start: > + LOAD_REG_IMMEDIATE(r1, stackptr) > + LOAD_REG_IMMEDIATE(r2, tocptr) > + bl hcall_patch_broken_sc1 Come to that, is there any point putting hcall_patch_broken_sc1 in C, rather than just doing it inline here. > + bl main > + bl exit > b halt > =20 > .text > +.align 3 > + > +.globl sc1 > +sc1: > + sc 1 > + blr > =20 > .globl halt > halt: --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --AbQceqfdZEv+FvjW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWw9UpAAoJEGw4ysog2bOSwm8QAKWdrg1hUJ7SSXfnhxZ+8t10 5jXU1GmrsGbLB0H1kGli+pxO7c7kuY/neIAnSnHCfztVzVSh9/SwPObF6A4hTb4y JjMBTqbCDlukVbhKoCSQOBCfUexAXr6/XQZZ0Ae4iVoDV/BFG+TdrB/pqvZLZTYO OrEU3Jij0bqlHdOTIRYzWv+HGVqsVNlr/0Lf+epaHBY4Ur1/lVXK+GMCGi3eW9rc FyBpogzetmP8CGRMCtwGmBbjqJB1qXCFPZkngQAaOGcASEpZ8oBVuMCzsHPn8v4D VfKO7lA0ROham9DfW97gzZ5Y34ZxL6usuPCGHoYqpvU8/05tWZ1QWpc7LtB//VTh 57pRKdAP/9Fy9+HB0Ek7cJwxC7TTHOBj5nJb/XO/a6jjmTvIq2XGC1MPPjM9+Mhw odpt1dEerJIfpKdhTolh1qPvs6ZdN2aigiI8rswEsVFXjoYtvXVibjaDOb0PlSJc 6TPEjv4D4nrfhaEuAL2TPUXMhgA72DehXtfpSYY0dPOpL/B9TTamjOluJItpWSzx gbqfex8QiBo45d76eUqX2xFH3Fiqwlh+6XKXuJ4VeYO8/VljDlVs6quJplHQvb5F 2vELF0rxi66nfbrf5vCfJaMs8l1goeaF00MSC4GwPPAgGD6GAMNeDYySCEZvzbjs dIXcMPYWvpyZ+bc3YXMM =73Fv -----END PGP SIGNATURE----- --AbQceqfdZEv+FvjW-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Date: Wed, 17 Feb 2016 02:04:25 +0000 Subject: Re: [kvm-unit-tests PATCH v4 11/17] powerpc/ppc64: add hcall support and putchar Message-Id: <20160217020425.GD5239@voom.redhat.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="AbQceqfdZEv+FvjW" List-Id: References: <1455544166-19766-1-git-send-email-drjones@redhat.com> <1455544166-19766-12-git-send-email-drjones@redhat.com> In-Reply-To: <1455544166-19766-12-git-send-email-drjones@redhat.com> To: Andrew Jones Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, thuth@redhat.com, dgibson@redhat.com, agraf@suse.de, lvivier@redhat.com, pbonzini@redhat.com --AbQceqfdZEv+FvjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 15, 2016 at 02:49:20PM +0100, Andrew Jones wrote: > Add broken sc1 detection and patching and an hcall for putchar, > to use in puts. That, along with a couple more lines in start to > prepare for C code, and a branch to main(), gets us "hello world". > Run with >=20 > qemu-system-ppc64 -M pseries \ > -bios powerpc/boot_rom.bin \ > -display none -serial stdio \ > -kernel powerpc/selftest.elf >=20 > (We're still not relocating yet, that comes in a later patch. Thus, > testing hello-world at this point requires a hacked QEMU and linking > the unit test at QEMU's kernel load address.) >=20 > Signed-off-by: Andrew Jones > Tested-by: Laurent Vivier > --- > lib/powerpc/asm/hcall.h | 46 ++++++++++++++++++++++++++++ > lib/powerpc/hcall.c | 79 +++++++++++++++++++++++++++++++++++++++++++= ++++++ > lib/powerpc/io.c | 15 ++++++++-- > lib/ppc64/asm/hcall.h | 1 + > powerpc/Makefile.common | 2 ++ > powerpc/cstart64.S | 21 +++++++++++++ > 6 files changed, 162 insertions(+), 2 deletions(-) > create mode 100644 lib/powerpc/asm/hcall.h > create mode 100644 lib/powerpc/hcall.c > create mode 100644 lib/ppc64/asm/hcall.h >=20 > diff --git a/lib/powerpc/asm/hcall.h b/lib/powerpc/asm/hcall.h > new file mode 100644 > index 0000000000000..f861287ac2083 > --- /dev/null > +++ b/lib/powerpc/asm/hcall.h > @@ -0,0 +1,46 @@ > +#ifndef _ASMPOWERPC_HCALL_H_ > +#define _ASMPOWERPC_HCALL_H_ > +/* > + * Copyright (C) 2016, Red Hat Inc, Andrew Jones > + * > + * This work is licensed under the terms of the GNU LGPL, version 2. > + */ > + > +#define SC1 0x44000022 > +#define SC1_REPLACEMENT 0x7c000268 > + > +#define H_SUCCESS 0 > +#define H_HARDWARE -1 > +#define H_FUNCTION -2 > +#define H_PRIVILEGE -3 > +#define H_PARAMETER -4 > + > +#define H_SET_DABR 0x28 > +#define H_PUT_TERM_CHAR 0x58 > + > +#ifndef __ASSEMBLY__ > +#include > + > +/* > + * hcall_have_broken_sc1 checks if we're on a host with a broken sc1. > + * Returns true if we are. > + */ > +extern bool hcall_have_broken_sc1(void); > + > +/* > + * hcall_patch_broken_sc1 patches hcall's sc1 instruction, if needed, > + * allowing all hypercalls built on it to work. > + */ > +extern void hcall_patch_broken_sc1(void); > + > +/* > + * hcall is the hypercall wrapper function. unittests may do what > + * they like, but the framework should make all hypercalls through > + * here to ensure they use a working sc1 instruction, and properly > + * handle clobbered registers. @nr is the hypercall number. > + */ > +extern unsigned long > +hcall(unsigned long nr, unsigned long *in, unsigned long *out); > + > +#endif /* !__ASSEMBLY__ */ > +#endif /* _ASMPOWERPC_HCALL_H_ */ > diff --git a/lib/powerpc/hcall.c b/lib/powerpc/hcall.c > new file mode 100644 > index 0000000000000..db99949352133 > --- /dev/null > +++ b/lib/powerpc/hcall.c > @@ -0,0 +1,79 @@ > +/* > + * Hypercall helpers > + * > + * broken_sc1 probing/patching inspired by SLOF, see > + * SLOF:lib/libhvcall/brokensc1.c > + * > + * hcall() implementation inspired by Linux's epapr_hypercall, see > + * arch/powerpc/include/asm/epapr_hcalls.h > + * > + * Copyright (C) 2016, Red Hat Inc, Andrew Jones > + * > + * This work is licensed under the terms of the GNU LGPL, version 2. > + */ > +#include > +#include > + > +static u32 sc1[]; > + > +bool hcall_have_broken_sc1(void) > +{ > + register unsigned long r3 asm("r3") =3D H_SET_DABR; > + register unsigned long r4 asm("r4") =3D 0; > + > + asm volatile("sc 1" > + : "=3Dr" (r3) > + : "r" (r3), "r" (r4) > + : "r5", "r6", "r7", "r8", "r9", "r10", "r11", "r12"); > + return r3 =3D=3D (unsigned long)H_PRIVILEGE; > +} > + > +void hcall_patch_broken_sc1(void) > +{ > + if (!hcall_have_broken_sc1()) > + return; > + sc1[0] =3D SC1_REPLACEMENT; > +} > + > +unsigned long hcall(unsigned long nr, unsigned long *in, unsigned long *= out) > +{ > + register unsigned long r3 asm("r3") =3D nr; > + register unsigned long r4 asm("r4") =3D in[0]; > + register unsigned long r5 asm("r5") =3D in[1]; > + register unsigned long r6 asm("r6") =3D in[2]; > + register unsigned long r7 asm("r7") =3D in[3]; > + register unsigned long r8 asm("r8") =3D in[4]; > + register unsigned long r9 asm("r9") =3D in[5]; > + register unsigned long r10 asm("r10") =3D in[6]; > + register unsigned long r11 asm("r11") =3D in[7]; > + > + asm volatile("bl sc1" > + : "=3Dr"(r3), "=3Dr"(r4), "=3Dr"(r5), "=3Dr"(r6), "=3Dr"(r7), > + "=3Dr"(r8), "=3Dr"(r9), "=3Dr"(r10), "=3Dr"(r11) > + : "r"(r3), "r"(r4), "r"(r5), "r"(r6), "r"(r7), > + "r"(r8), "r"(r9), "r"(r10), "r"(r11) > + : "r12", "memory", "lr"); > + > + out[0] =3D r4; > + out[1] =3D r5; > + out[2] =3D r6; > + out[3] =3D r7; > + out[4] =3D r8; > + out[5] =3D r9; > + out[6] =3D r10; > + out[7] =3D r11; > + > + return r3; I'm not sure there's much advantage to having this in C, rather than folding this and the sc1 symbol into a single asm implemented hcall function. Doing it that way might more easily allow you to avoid packing the arguments into an array, before unpacking them into registers again, which seems a bit perverse. > +} > + > +void putchar(int c) > +{ > + unsigned long in[8], out[8]; > + > + in[0] =3D 0; /* default vty */ > + in[1] =3D 1; /* just 1 byte */ > + in[2] =3D (unsigned long)c << 56; > + > + hcall(H_PUT_TERM_CHAR, in, out); > +} > diff --git a/lib/powerpc/io.c b/lib/powerpc/io.c > index 0af45742fc900..5e1fa8dd96ab6 100644 > --- a/lib/powerpc/io.c > +++ b/lib/powerpc/io.c > @@ -6,15 +6,26 @@ > * This work is licensed under the terms of the GNU LGPL, version 2. > */ > #include > +#include > + > +extern void halt(int code); > +extern void putchar(int c); > + > +static struct spinlock uart_lock; > =20 > void io_init(void) > { > } > =20 > -void puts(const char *s __unused) > +void puts(const char *s) > { > + spin_lock(&uart_lock); The name uart_lock isn't really accurate, since it's a hypervisor console rather than serial. > + while (*s) > + putchar(*s++); > + spin_unlock(&uart_lock); > } > =20 > -void exit(int code __unused) > +void exit(int code) > { > + halt(code); > } > diff --git a/lib/ppc64/asm/hcall.h b/lib/ppc64/asm/hcall.h > new file mode 100644 > index 0000000000000..daabaca510cd4 > --- /dev/null > +++ b/lib/ppc64/asm/hcall.h > @@ -0,0 +1 @@ > +#include "../../powerpc/asm/hcall.h" > diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common > index 0c3eaba0d3aab..89610b525f0c1 100644 > --- a/powerpc/Makefile.common > +++ b/powerpc/Makefile.common > @@ -21,6 +21,7 @@ CFLAGS +=3D -ffreestanding > CFLAGS +=3D -Wextra > CFLAGS +=3D -O2 > CFLAGS +=3D -I lib -I lib/libfdt > +CFLAGS +=3D -Wa,-mregnames > =20 > asm-offsets =3D lib/$(ARCH)/asm-offsets.h > include scripts/asm-offsets.mak > @@ -29,6 +30,7 @@ cflatobjs +=3D lib/util.o > cflatobjs +=3D lib/alloc.o > cflatobjs +=3D lib/devicetree.o > cflatobjs +=3D lib/powerpc/io.o > +cflatobjs +=3D lib/powerpc/hcall.o > =20 > libgcc :=3D $(shell $(CC) $(machine) --print-libgcc-file-name) > start_addr :=3D $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offse= t) ))) > diff --git a/powerpc/cstart64.S b/powerpc/cstart64.S > index f90828dee1c19..623fd693b02d1 100644 > --- a/powerpc/cstart64.S > +++ b/powerpc/cstart64.S > @@ -7,13 +7,34 @@ > */ > #define __ASSEMBLY__ > =20 > +#define LOAD_REG_IMMEDIATE(reg,expr) \ > + lis reg,(expr)@highest; \ > + ori reg,reg,(expr)@higher; \ > + rldicr reg,reg,32,31; \ > + oris reg,reg,(expr)@h; \ > + ori reg,reg,(expr)@l; > + > +#define LOAD_REG_ADDR(reg,name) \ > + ld reg,name@got(r2) > + > .section .init > =20 > .globl start > start: > + LOAD_REG_IMMEDIATE(r1, stackptr) > + LOAD_REG_IMMEDIATE(r2, tocptr) > + bl hcall_patch_broken_sc1 Come to that, is there any point putting hcall_patch_broken_sc1 in C, rather than just doing it inline here. > + bl main > + bl exit > b halt > =20 > .text > +.align 3 > + > +.globl sc1 > +sc1: > + sc 1 > + blr > =20 > .globl halt > halt: --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --AbQceqfdZEv+FvjW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWw9UpAAoJEGw4ysog2bOSwm8QAKWdrg1hUJ7SSXfnhxZ+8t10 5jXU1GmrsGbLB0H1kGli+pxO7c7kuY/neIAnSnHCfztVzVSh9/SwPObF6A4hTb4y JjMBTqbCDlukVbhKoCSQOBCfUexAXr6/XQZZ0Ae4iVoDV/BFG+TdrB/pqvZLZTYO OrEU3Jij0bqlHdOTIRYzWv+HGVqsVNlr/0Lf+epaHBY4Ur1/lVXK+GMCGi3eW9rc FyBpogzetmP8CGRMCtwGmBbjqJB1qXCFPZkngQAaOGcASEpZ8oBVuMCzsHPn8v4D VfKO7lA0ROham9DfW97gzZ5Y34ZxL6usuPCGHoYqpvU8/05tWZ1QWpc7LtB//VTh 57pRKdAP/9Fy9+HB0Ek7cJwxC7TTHOBj5nJb/XO/a6jjmTvIq2XGC1MPPjM9+Mhw odpt1dEerJIfpKdhTolh1qPvs6ZdN2aigiI8rswEsVFXjoYtvXVibjaDOb0PlSJc 6TPEjv4D4nrfhaEuAL2TPUXMhgA72DehXtfpSYY0dPOpL/B9TTamjOluJItpWSzx gbqfex8QiBo45d76eUqX2xFH3Fiqwlh+6XKXuJ4VeYO8/VljDlVs6quJplHQvb5F 2vELF0rxi66nfbrf5vCfJaMs8l1goeaF00MSC4GwPPAgGD6GAMNeDYySCEZvzbjs dIXcMPYWvpyZ+bc3YXMM =73Fv -----END PGP SIGNATURE----- --AbQceqfdZEv+FvjW--