From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 12/15] xfs: use vfs inode nlink field everywhere
Date: Tue, 16 Feb 2016 23:35:06 -0800 [thread overview]
Message-ID: <20160217073506.GC16363@infradead.org> (raw)
In-Reply-To: <1455693652-3899-13-git-send-email-david@fromorbit.com>
> index 685c7a7..1408be3 100644
> --- a/libxfs/libxfs_api_defs.h
> +++ b/libxfs/libxfs_api_defs.h
> @@ -108,4 +108,8 @@
>
> #define xfs_verify_cksum libxfs_verify_cksum
>
> +/* inode link counts */
> +#define set_nlink(inode, nlink) ({ (inode)->i_nlink = (nlink); })
> +#define inc_nlink(inode) (inode)->i_nlink++
Can we defines these as inlines?
> + ip->i_vnode.i_nlink++; /* account for . */
Shouldn't we use VFS_I() like everywhere else?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-17 7:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 7:20 [PATCH 00/15] xfsprogs: libxfs kernel sync to 4.6-for-next Dave Chinner
2016-02-17 7:20 ` [PATCH 01/15] xfs: wire up Q_XGETNEXTQUOTA / get_nextdqblk Dave Chinner
2016-02-17 7:25 ` Christoph Hellwig
2016-02-17 7:20 ` [PATCH 02/15] xfs: handle errors from ->free_blocks in xfs_btree_kill_iroot Dave Chinner
2016-02-17 7:20 ` [PATCH 03/15] xfs: factor btree block freeing into a helper Dave Chinner
2016-02-17 7:20 ` [PATCH 04/15] xfs: move buffer invalidation to xfs_btree_free_block Dave Chinner
2016-02-17 7:20 ` [PATCH 05/15] xfs: remove unused function definitions Dave Chinner
2016-02-17 7:20 ` [PATCH 06/15] xfs: RT bitmap and summary buffers are not typed Dave Chinner
2016-02-17 7:20 ` [PATCH 07/15] xfs: RT bitmap and summary buffers need verifiers Dave Chinner
2016-02-17 7:20 ` [PATCH 08/15] xfs: introduce inode log format object Dave Chinner
2016-02-17 7:20 ` [PATCH 09/15] xfs: remove timestamps from incore inode Dave Chinner
2016-02-26 18:02 ` Brian Foster
2016-02-26 19:35 ` Darrick J. Wong
2016-02-17 7:20 ` [PATCH 10/15] xfs: cull unnecessary icdinode fields Dave Chinner
2016-02-17 7:20 ` [PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk Dave Chinner
2016-02-17 7:32 ` Christoph Hellwig
2016-02-17 7:48 ` Dave Chinner
2016-02-17 8:30 ` Dave Chinner
2016-02-17 8:33 ` Christoph Hellwig
2016-02-17 9:30 ` Dave Chinner
2016-02-17 7:20 ` [PATCH 12/15] xfs: use vfs inode nlink field everywhere Dave Chinner
2016-02-17 7:35 ` Christoph Hellwig [this message]
2016-02-17 7:49 ` Dave Chinner
2016-02-17 7:20 ` [PATCH 13/15] xfs: move inode generation count to VFS inode Dave Chinner
2016-02-17 7:20 ` [PATCH 14/15] xfs: move di_changecount " Dave Chinner
2016-02-17 7:20 ` [PATCH 15/15] xfs: mode di_mode to vfs inode Dave Chinner
2016-02-17 7:56 ` [PATCH 00/15] xfsprogs: libxfs kernel sync to 4.6-for-next Christoph Hellwig
2016-02-17 8:16 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217073506.GC16363@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.