From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426075AbcBROPc (ORCPT ); Thu, 18 Feb 2016 09:15:32 -0500 Received: from smtprelay0211.hostedemail.com ([216.40.44.211]:40368 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1425356AbcBROPb (ORCPT ); Thu, 18 Feb 2016 09:15:31 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3871:3872:3873:3874:4470:5007:6261:7875:7903:10004:10400:10450:10455:10848:10967:11232:11658:11914:12296:12517:12519:12740:13069:13160:13229:13311:13357:14096:14097:14659:19904:19999:21063:21080:21324:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: mouth35_872f8c715a408 X-Filterd-Recvd-Size: 2213 Date: Thu, 18 Feb 2016 09:15:28 -0500 From: Steven Rostedt To: LKML Cc: Peter Zijlstra , Juri Lelli , Ingo Molnar , Clark Williams , Daniel Bristot de Oliveira , John Kacur , Thomas Gleixner Subject: Re: [RFC][PATCH] sched: Kick bandwidth timer immediately on start up Message-ID: <20160218091528.6c05c181@gandalf.local.home> In-Reply-To: <20160216183746.349ec98b@gandalf.local.home> References: <20160216183746.349ec98b@gandalf.local.home> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Feb 2016 18:37:46 -0500 Steven Rostedt wrote: > > A better solution may be to subtract the bandwidth that the deadline > task uses from the rt_runtime, and add it back when its finished. Then > there wont be a need for runtime tracking of the time used by deadline > tasks. > > I may play with that solution tomorrow. > OK, so I played with this solution. It's much more complex than I was hoping it to be. The main issue is there's no one to one relationship with the deadline bandwidth and the rt bandwidth. Each runqueue has its own rt ratio, but each root domain that has its own deadline ratio. Thus, when you add to the dl ratio, it makes adding that to the rt bandwidths that more complex. It's doable, but it will make getting the dl_bw right with new root domains harder than it already is, and that is currently not working. My recommendation is to hold off on a better solution till we can find a way to merge rt bandwidth with the Constant Bandwidth Server (CBS). Thus, please accept this current patch as it appears to fix the problem without any other side effects that I can find. -- Steve