All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] Test library API changes
Date: Thu, 18 Feb 2016 12:07:53 +0100	[thread overview]
Message-ID: <20160218110752.GB19157@rei.lan> (raw)
In-Reply-To: <1752902661.22105327.1455786359593.JavaMail.zimbra@redhat.com>

Hi!
> > > 2. Can we keep ltp_syscall() and call correct brk func with some magic?
> > 
> > Well we can split the header as we did with the rest of them, do you
> > think that it's worth of it?
> 
> I was thinking some ifdef magic. It has same signature in both
> versions of API, so adding new function with different name,
> that does pretty much the same seems like unnecessary complication.

My reasoning was different. There are only two functions that start with
ltp_ in the library the ltp_syscall and ltp_clone. So the reason for
rename is unifying on tst_ and it was convinient in this case as well.
But I do not care that much about this. If you think keeping
ltp_syscall() is better, then we can go for it.

> > > 5c) What if we stored ipc path to env variable?
> > > 
> > > setup_ipc
> > >   generates tmp name based on test name: ltp_ipc_path
> > >   for convenience will initialize also envp array:
> > >     ltp_only_ipc_env[] = { "LTP_IPC_PATH="$ltp_ipc_path, NULL }
> > >   creates ipc file
> > 
> > Hmm, that way the test would have to explicitly pass it to the execve().
> 
> True, but it would be rare, as you said it's for ~10 testcases.
> 
> > 
> > I would rather make it reasonably unique but decideable without
> > explicitly passing variables around.
> 
> Should we consider multiple instances running at a time? I do
> recall that tools/pounder21 allows running things in parallel.
> (Not sure if anyone runs more instances of same test though)

I think that disabling the possibility just to make writing the test
library a bit easier is pretty bad idea. Most of the testcases we have
can run in parallel just fine. There are only a few that stress the
system to the limit or use global resources (devices, IPC, change system
time, ...) and if we anotate these tests we can easily speed up the test
run five times just by running most of the testcases in parallel.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2016-02-18 11:07 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 11:11 [LTP] Test library API changes Cyril Hrubis
2016-01-07 13:01 ` Jan Stancek
2016-01-07 13:27   ` Cyril Hrubis
2016-02-04 10:56   ` Cyril Hrubis
2016-02-08 18:02     ` Cyril Hrubis
2016-02-09 16:43       ` Cyril Hrubis
2016-02-09 16:57         ` Cyril Hrubis
2016-02-09 17:46           ` Cyril Hrubis
2016-02-10 10:42             ` Jan Stancek
2016-02-10 10:56               ` Cyril Hrubis
2016-02-10 11:41               ` Cyril Hrubis
2016-02-11 16:03                 ` Cyril Hrubis
2016-02-12 12:33                   ` Jan Stancek
2016-02-12 17:53                     ` Cyril Hrubis
2016-02-16 21:19                       ` Cyril Hrubis
2016-02-17 14:39                         ` Jan Stancek
2016-02-17 15:54                           ` Cyril Hrubis
2016-02-18  9:05                             ` Jan Stancek
2016-02-18 11:07                               ` Cyril Hrubis [this message]
2016-02-18 11:26                                 ` Jan Stancek
2016-02-18 11:53                                   ` Cyril Hrubis
2016-03-02 14:44                                   ` Cyril Hrubis
2016-03-03 13:13                                     ` Jan Stancek
2016-03-03 14:00                                       ` Cyril Hrubis
2016-03-10 16:57                                         ` Cyril Hrubis
2016-03-11 13:57                                           ` Jan Stancek
2016-03-14 12:51                                             ` Cyril Hrubis
2016-03-14 16:00                                               ` Cyril Hrubis
2016-03-15  8:58                                                 ` Jan Stancek
2016-03-15  9:22                                                   ` Cyril Hrubis
2016-03-17 16:06                                                     ` Cyril Hrubis
2016-03-18  9:44                                                       ` Jan Stancek
2016-03-31 10:01                                                         ` Cyril Hrubis
2016-04-01 14:45                                                           ` Jan Stancek
2016-04-04 12:04                                                             ` Cyril Hrubis
2016-04-04 14:12                                                               ` Jan Stancek
2016-04-05 14:16                                                                 ` Cyril Hrubis
2016-04-05 15:06                                                                   ` Jan Stancek
2016-04-06 10:37                                                                     ` Cyril Hrubis
2016-03-14 16:40                                             ` Cyril Hrubis
2016-02-18  9:14                             ` Alexey Kodanev
2016-02-18 10:40                               ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218110752.GB19157@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.