From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:49854 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751166AbcBSWc2 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 19 Feb 2016 17:32:28 -0500
Date: Fri, 19 Feb 2016 22:32:26 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mike Marshall <hubcap@omnibond.com>
Cc: Martin Brandenburg <martin@omnibond.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: Orangefs ABI documentation
Message-ID: <20160219223226.GD17997@ZenIV.linux.org.uk>
References: <20160218111122.GS17997@ZenIV.linux.org.uk>
 <CAOg9mSS11uSvfBkNYPeNBw8xMebvHAM3vzh82BH=W273-7oNyg@mail.gmail.com>
 <alpine.BSO.2.20.1602181449280.29280@server1.sysblue.org>
 <CAOg9mSSRebK0WMQHVD3Ne7R0+sdzO+o-mJcxX626X6UzEFsPpg@mail.gmail.com>
 <CAOg9mST9mPefWaWNqXieuQQeLdLDXOtS3atk_+JzJXX9G6b+gg@mail.gmail.com>
 <CAOg9mSRWeNV_DbRw1Zn2XzwW+7ORWcYLj85P-3rvZ0YisLzT9g@mail.gmail.com>
 <20160218205206.GW17997@ZenIV.linux.org.uk>
 <CAOg9mSQQCATxLS0qoKrs-k3HktquBtNRQsCA6ePeDSyW-cT2bg@mail.gmail.com>
 <20160219002539.GX17997@ZenIV.linux.org.uk>
 <CAOg9mSRVD6W7yW_Usa5945cOHPsvFHvzj9fjoEHRj+u+fDX0ZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOg9mSRVD6W7yW_Usa5945cOHPsvFHvzj9fjoEHRj+u+fDX0ZA@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Feb 19, 2016 at 05:11:29PM -0500, Mike Marshall wrote:

> Boo! Now a new problem is uncovered, I don't have a handle on it yet.
> Now it is possible to create a broken file on the orangefs server
> across a restart of the client-core.

I suspect that it's your "getattr after create and leave dentry negative if
that getattr fails".  Might make sense to d_drop() the sucker in case of
such late failure - or mark it so that subsequent d_revalidate() would
*not* skip getattr, despite NULL ->d_inode.

Incidentally, why does your ->d_revalidate() bother with d_drop()?  Just
have it return 0 and let the caller DTRT...