From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758377AbcB1PgP (ORCPT ); Sun, 28 Feb 2016 10:36:15 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34417 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758035AbcB1PgL (ORCPT ); Sun, 28 Feb 2016 10:36:11 -0500 Date: Sun, 28 Feb 2016 16:36:16 +0100 From: Johan Hovold To: Daniele Palmas Cc: Johan Hovold , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] usb: serial: option: Adding support for Telit LE922 PID 0x1045 Message-ID: <20160228153616.GF32461@localhost> References: <1456490127-14112-1-git-send-email-dnlplm@gmail.com> <1456490127-14112-2-git-send-email-dnlplm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456490127-14112-2-git-send-email-dnlplm@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2016 at 01:35:27PM +0100, Daniele Palmas wrote: > This patch adds support for 0x1045 PID of Telit LE922. > > Signed-off-by: Daniele Palmas > --- > drivers/usb/serial/option.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index db86e51..4be2c7c 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -270,6 +270,7 @@ static void option_instat_callback(struct urb *urb); > #define TELIT_PRODUCT_UE910_V2 0x1012 > #define TELIT_PRODUCT_LE922_USBCFG0 0x1042 > #define TELIT_PRODUCT_LE922_USBCFG3 0x1043 > +#define TELIT_PRODUCT_LE922_USBCFG5 0x1045 > #define TELIT_PRODUCT_LE920 0x1200 > #define TELIT_PRODUCT_LE910 0x1201 > > @@ -627,6 +628,11 @@ static const struct option_blacklist_info telit_le922_blacklist_usbcfg3 = { > .reserved = BIT(1) | BIT(2) | BIT(3), > }; > > +static const struct option_blacklist_info telit_le922_blacklist_usbcfg5 = { > + .sendsetup = BIT(2), > + .reserved = BIT(0) | BIT(1) | BIT(3) | BIT(8) | BIT(9) | BIT(10), > +}; > + > static const struct usb_device_id option_ids[] = { > { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) }, > { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_RICOLA) }, > @@ -1176,6 +1182,8 @@ static const struct usb_device_id option_ids[] = { > .driver_info = (kernel_ulong_t)&telit_le922_blacklist_usbcfg0 }, > { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_LE922_USBCFG3), > .driver_info = (kernel_ulong_t)&telit_le922_blacklist_usbcfg3 }, > + { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_LE922_USBCFG5), > + .driver_info = (kernel_ulong_t)&telit_le922_blacklist_usbcfg5 }, Please use USB_DEVICE_INTERFACE_CLASS to keep the blacklist entry shorter (perhaps you can then even reuse an existing one). Thanks, Johan