From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754347AbcB2M7z (ORCPT ); Mon, 29 Feb 2016 07:59:55 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:36531 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754261AbcB2M7w (ORCPT ); Mon, 29 Feb 2016 07:59:52 -0500 Date: Mon, 29 Feb 2016 13:59:48 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Matthew Garrett , Darren Hart , Darek Stojaczyk , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Message-ID: <20160229125948.GI21814@pali> References: <1455634230-1487-1-git-send-email-kernel@kempniu.pl> <1456298416-29683-1-git-send-email-kernel@kempniu.pl> <1456298416-29683-5-git-send-email-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1456298416-29683-5-git-send-email-kernel@kempniu.pl> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 24 February 2016 08:20:14 Michał Kępień wrote: > On models on which an SMBIOS request needs to be issued in order for WMI > events to be generated, pressing the Dell Instant Launch hotkey does not > raise an i8042 interrupt - only a WMI event is generated (0xe025 on Dell > Vostro V131). Thus, the 0xe025 event should only be ignored on machines > which do not require an SMBIOS request for enabling WMI. > > Signed-off-by: Michał Kępień > --- > drivers/platform/x86/dell-wmi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > index 65edd93..ffc957b5 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -111,7 +111,7 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = { > { KE_IGNORE, 0xe020, { KEY_MUTE } }, > > /* Shortcut and audio panel keys */ > - { KE_IGNORE, 0xe025, { KEY_RESERVED } }, > + { KE_KEY, 0xe025, { KEY_PROG4 } }, > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > { KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } }, > @@ -235,6 +235,9 @@ static void dell_wmi_process_key(int reported_key) > acpi_video_handles_brightness_key_presses()) > return; > > + if (key->keycode == KEY_PROG4 && !wmi_requires_smbios_request) > + return; > + Here I would rather test against reported_key, not keycode. If somebody in future adds KEY_PROG4 for something else we will have problem... > sparse_keymap_report_entry(dell_wmi_input_dev, key, 1, true); > } > -- Pali Rohár pali.rohar@gmail.com