From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754274AbcB2Oq2 (ORCPT ); Mon, 29 Feb 2016 09:46:28 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:46454 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbcB2Oq0 convert rfc822-to-8bit (ORCPT ); Mon, 29 Feb 2016 09:46:26 -0500 Date: Mon, 29 Feb 2016 14:45:28 +0000 From: One Thousand Gnomes To: Sergei Ianovich Cc: Andy Shevchenko , linux-kernel@vger.kernel.org, Arnd Bergmann , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Greg Kroah-Hartman , Jiri Slaby , Heikki Krogerus , Masahiro Yamada , Paul Burton , Paul Gortmaker , Mans Rullgard , Scott Wood , Joachim Eastwood , Peter Ujfalusi , Peter Hurley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:SERIAL DRIVERS" Subject: Re: [PATCH v6] serial: support for 16550A serial ports on LP-8x4x Message-ID: <20160229144528.0c0b8371@lxorguk.ukuu.org.uk> In-Reply-To: <1456750995.23036.87.camel@gmail.com> References: <1450213494-21884-1-git-send-email-ynvich@gmail.com> <1456589675-25377-1-git-send-email-ynvich@gmail.com> <1456741786.13244.167.camel@linux.intel.com> <1456750995.23036.87.camel@gmail.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I haven't tested this mode. I am pretty sure it will fail. There is > also no support for speeds higher than 115200. > > CS7 and CS8 at speeds up to 115200 work well. > > However, there is no way to report errors from set_termios(). Should > anything be done about those limitations? You report back by setting the termios fields to the values actually selected. Eg if you can't do CS5/CS6 you'd pick CS7 or CS8 and write that back into tty->termios so the caller knows what they actually got. Ditto for speed (see the 16550A core driver for the speed write backs). Alan From mboxrd@z Thu Jan 1 00:00:00 1970 From: One Thousand Gnomes Subject: Re: [PATCH v6] serial: support for 16550A serial ports on LP-8x4x Date: Mon, 29 Feb 2016 14:45:28 +0000 Message-ID: <20160229144528.0c0b8371@lxorguk.ukuu.org.uk> References: <1450213494-21884-1-git-send-email-ynvich@gmail.com> <1456589675-25377-1-git-send-email-ynvich@gmail.com> <1456741786.13244.167.camel@linux.intel.com> <1456750995.23036.87.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1456750995.23036.87.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sergei Ianovich Cc: Andy Shevchenko , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Arnd Bergmann , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Greg Kroah-Hartman , Jiri Slaby , Heikki Krogerus , Masahiro Yamada , Paul Burton , Paul Gortmaker , Mans Rullgard , Scott Wood , Joachim Eastwood , Peter Ujfalusi , Peter Hurley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" "open list:SERIAL DRIVERS" List-Id: devicetree@vger.kernel.org > I haven't tested this mode. I am pretty sure it will fail. There is > also no support for speeds higher than 115200. >=20 > CS7 and CS8 at speeds up to 115200 work well. >=20 > However, there is no way to report errors from=C2=A0set_termios(). Sh= ould > anything be done about those limitations? You report back by setting the termios fields to the values actually selected. Eg if you can't do CS5/CS6 you'd pick CS7 or CS8 and write th= at back into tty->termios so the caller knows what they actually got. Ditt= o for speed (see the 16550A core driver for the speed write backs). Alan -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html