All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>,
	Karsten Blees <karsten.blees@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: GIT_TRACE_PERFORMANCE and pager
Date: Mon, 29 Feb 2016 16:30:27 -0500	[thread overview]
Message-ID: <20160229213026.GB25342@sigill.intra.peff.net> (raw)
In-Reply-To: <CAP8UFD30fWvFPtSgY_6mVMCeQ9rMR-0EODaKbZdMmz_fo-qfKw@mail.gmail.com>

On Mon, Feb 29, 2016 at 02:46:12PM +0100, Christian Couder wrote:

> > though I guess I'd question whether trace-performance is interesting at
> > all for a paged command, since it is also counting the length of time
> > you spend looking at the pager waiting to hit "q".
> 
> In case of "GIT_TRACE_PERFORMANCE=2 git log -1", it doesn't count the
> time spent looking at the pager because the output is small, so 'less'
> exits immediately, and it could give the impression that
> GIT_TRACE_PERFORMANCE is not working.

Ah, right. I don't use "-F" with less, so mine hangs around until I
quit.

-Peff

  reply	other threads:[~2016-02-29 21:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 11:25 GIT_TRACE_PERFORMANCE and pager Christian Couder
2016-02-29 11:39 ` Jeff King
2016-02-29 13:46   ` Christian Couder
2016-02-29 21:30     ` Jeff King [this message]
2016-02-29 16:47   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160229213026.GB25342@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karsten.blees@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.