From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753765AbcCBQm4 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Mar 2016 11:42:56 -0500
Received: from casper.infradead.org ([85.118.1.10]:40429 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750797AbcCBQmy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Mar 2016 11:42:54 -0500
Date: Wed, 2 Mar 2016 17:42:49 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sedat Dilek <sedat.dilek@gmail.com>, Jiri Kosina <jikos@kernel.org>,
        Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        Andy Lutomirski <luto@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        linux-usb@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>, Felipe Balbi <balbi@ti.com>,
        Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning
Message-ID: <20160302164249.GJ6357@twins.programming.kicks-ass.net>
References: <CA+icZUWagGMVNs5gBPRBhYO0LsY2A1hK3KSLabp9ZpDVOTmtig@mail.gmail.com>
 <20151012205755.7ad86f4c@grimm.local.home>
 <CA+icZUUCNAUDVqg1D-brJtZ2_QRxW_2s+jv0T5MPpCE9Y-auvg@mail.gmail.com>
 <20160301100740.759440b7@gandalf.local.home>
 <20160301151700.GU6356@twins.programming.kicks-ass.net>
 <CA+icZUVgo0FSZ17ZgA4kyBSzFuNx7aMi6FxH6MdbJYxzi+1V4A@mail.gmail.com>
 <20160302151713.GG6357@twins.programming.kicks-ass.net>
 <CA+icZUWvduot+7Tnm9w8ETj-dzEs=7Mp1ZchLcK5TDYBNmPFXQ@mail.gmail.com>
 <20160302162412.GI6357@twins.programming.kicks-ass.net>
 <20160302113535.6abe9a2c@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160302113535.6abe9a2c@gandalf.local.home>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 02, 2016 at 11:35:35AM -0500, Steven Rostedt wrote:
> On Wed, 2 Mar 2016 17:24:12 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > On Wed, Mar 02, 2016 at 04:53:36PM +0100, Sedat Dilek wrote:
> > > ffffffff8110f570 <del_timer_sync>:
> > > ffffffff8110f570:	55                   	push   %rbp
> > > ffffffff8110f571:	48 89 e5             	mov    %rsp,%rbp
> > > ffffffff8110f574:	41 57                	push   %r15
> > > ffffffff8110f576:	41 56                	push   %r14
> > > ffffffff8110f578:	53                   	push   %rbx
> > > ffffffff8110f579:	48 83 ec 28          	sub    $0x28,%rsp  
> > 
> > stack offset is 0x28 bytes [*]
> 
> Actually, isn't it really 0x40 bytes? The stack pushed 3 words (8 bytes
> each) before doing the subtract. 0x28 == 40 bytes, 3 * 8 = 24,
> 40 + 24 = 64 == 0x40.

> > > ffffffff8110f5fd:	4c 89 75 d0          	mov    %r14,-0x30(%rbp)
> > > ffffffff8110f601:	ff 75 d0             	pushq  -0x30(%rbp)
> > > ffffffff8110f604:	9d                   	popfq    
> > 
> > put r14 into -0x30(rbp) and pushes/pops that, see [*] this is 8 bytes
> > over stack ?!
> 
> But from rbp, the stack is 0x40 bytes. This may be fine.

Ah indeed.