From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756780AbcCBSdZ (ORCPT ); Wed, 2 Mar 2016 13:33:25 -0500 Received: from mail.kernel.org ([198.145.29.136]:48688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891AbcCBSdV (ORCPT ); Wed, 2 Mar 2016 13:33:21 -0500 Date: Wed, 2 Mar 2016 12:33:09 -0600 From: Rob Herring To: Alexandre TORGUE Cc: Maxime Coquelin , Giuseppe Cavallaro , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 2/4] Documentation: Bindings: Add STM32 DWMAC glue Message-ID: <20160302183309.GA2449@rob-hp-laptop> References: <1456483912-32090-1-git-send-email-alexandre.torgue@gmail.com> <1456483912-32090-3-git-send-email-alexandre.torgue@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456483912-32090-3-git-send-email-alexandre.torgue@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2016 at 11:51:50AM +0100, Alexandre TORGUE wrote: > Signed-off-by: Alexandre TORGUE > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > new file mode 100644 > index 0000000..67fceda > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > @@ -0,0 +1,40 @@ > +STMicroelectronics STM32 / MCU DWMAC glue layer controller > + > +This file documents platform glue layer for stmmac. > +Please see stmmac.txt for the other unchanged properties. > + > +The device node has following properties. > + > +Required properties: > +- compatible: Should be "st,stm32-dwmac" to select glue, and > + "snps,dwmac-3.50a" to select IP vesrion. > +- clocks: Should contain the GMAC main clock, and tx clock > +- compatible: Should be "st,stm32-dwmac" to select glue and > + "snps,dwmac-3.50a" to select IP version. > +- clocks: Should contain the MAC main clock > +- clock-names: Should contain the clock names "stmmaceth". > +- st,syscon : Should be phandle/offset pair. The phandle to the syscon node which > + encompases the glue register, and the offset of the control register. > + > +Optional properties: > +- clocks: Could contain: > + - the tx clock, > + - the rx clock > +- clock-names: Could contain the clock names "tx-clk", "rx-clk" Either the IP block has 3 clocks or it has 1. If you have a case where 1 clock feeds all 3 inputs, then list the clock 3 times. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Wed, 2 Mar 2016 12:33:09 -0600 Subject: [PATCH v3 2/4] Documentation: Bindings: Add STM32 DWMAC glue In-Reply-To: <1456483912-32090-3-git-send-email-alexandre.torgue@gmail.com> References: <1456483912-32090-1-git-send-email-alexandre.torgue@gmail.com> <1456483912-32090-3-git-send-email-alexandre.torgue@gmail.com> Message-ID: <20160302183309.GA2449@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 26, 2016 at 11:51:50AM +0100, Alexandre TORGUE wrote: > Signed-off-by: Alexandre TORGUE > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > new file mode 100644 > index 0000000..67fceda > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > @@ -0,0 +1,40 @@ > +STMicroelectronics STM32 / MCU DWMAC glue layer controller > + > +This file documents platform glue layer for stmmac. > +Please see stmmac.txt for the other unchanged properties. > + > +The device node has following properties. > + > +Required properties: > +- compatible: Should be "st,stm32-dwmac" to select glue, and > + "snps,dwmac-3.50a" to select IP vesrion. > +- clocks: Should contain the GMAC main clock, and tx clock > +- compatible: Should be "st,stm32-dwmac" to select glue and > + "snps,dwmac-3.50a" to select IP version. > +- clocks: Should contain the MAC main clock > +- clock-names: Should contain the clock names "stmmaceth". > +- st,syscon : Should be phandle/offset pair. The phandle to the syscon node which > + encompases the glue register, and the offset of the control register. > + > +Optional properties: > +- clocks: Could contain: > + - the tx clock, > + - the rx clock > +- clock-names: Could contain the clock names "tx-clk", "rx-clk" Either the IP block has 3 clocks or it has 1. If you have a case where 1 clock feeds all 3 inputs, then list the clock 3 times. Rob