From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757384AbcCCMua (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Mar 2016 07:50:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48622 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754049AbcCCMu3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Mar 2016 07:50:29 -0500
Date: Thu, 3 Mar 2016 09:50:27 -0300
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>, Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 05/11] perf stat: Check existence of frontend/backed
 stalled cycles
Message-ID: <20160303125027.GC2528@redhat.com>
References: <1456773727-3005-1-git-send-email-acme@kernel.org>
 <1456773727-3005-6-git-send-email-acme@kernel.org>
 <20160303082818.GB13523@gmail.com>
 <20160303124900.GB2528@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160303124900.GB2528@redhat.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.20 (2009-12-10)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 03 Mar 2016 12:50:29 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Mar 03, 2016 at 09:49:00AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Mar 03, 2016 at 09:28:18AM +0100, Ingo Molnar escreveu:
> > 
> > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > 
> > > Before:
> > > 
> > >   $ perf stat ls
> > >   a.patch
> > > 
> > >   Performance counter stats for 'ls':
> > > 
> > >          0.822067 task-clock (msec)   #   0.873 CPUs utilized   (82.26%)
> > >                 0 context-switches    #   0.000 K/sec           (82.26%)
> > >                 0 cpu-migrations      #   0.000 K/sec           (82.26%)
> > >               125 page-faults         #   0.152 M/sec           (82.26%)
> > >         2,516,127 cycles              #   3.061 GHz             (82.84%)
> > >   <not supported> stalled-cycles-frontend
> > >   <not supported> stalled-cycles-backend
> > >         2,430,467 instructions        #   0.97  insn per cycle  (82.84%)
> > >           486,235 branches            # 591.479 M/sec           (82.84%)
> > >            18,389 branch-misses       #   3.78% of all branches (82.84%)
> > > 
> > >       0.000941536 seconds time elapsed
> > >   $
> > > 
> > > After:
> > > 
> > >   $ perf stat ls
> > >   a.patch
> > > 
> > >   Performance counter stats for 'ls':
> > > 
> > >          0.824919 task-clock (msec)   #   0.893 CPUs utilized   (85.47%)
> > >                 0 context-switches    #   0.000 K/sec           (85.47%)
> > >                 0 cpu-migrations      #   0.000 K/sec           (85.47%)
> > >               124 page-faults         #   0.150 M/sec           (85.47%)
> > >           2521790 cycles              #   3.057 GHz             (86.15%)
> > >           2364913 instructions        #   0.94  insn per cycle  (86.15%)
> > >            471970 branches            # 572.141 M/sec           (86.15%)
> > >             16935 branch-misses       #   3.59% of all branches (86.15%)
> > > 
> > >       0.000923397 seconds time elapsed
> > >   $
> > 
> > Btw., the output format regression is visible in this changelog already...
> 
> Right, uf, should've pick this up at this point :-\
> 
> Will go back and fix it up, so that we don't introduce a regression.

Well, in this case its not a matter of fixing the patch, but making sure
that Jiri's locale pmu parsing fix comes before this patch, so inserting
a patch, will do.

- Arnaldo