From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH v3 01/16] libxc: Rework extra module initialisation Date: Thu, 3 Mar 2016 16:27:08 +0000 Message-ID: <20160303162708.GK7532@perard.uk.xensource.com> References: <1456412174-20162-1-git-send-email-anthony.perard@citrix.com> <1456412174-20162-2-git-send-email-anthony.perard@citrix.com> <20160301115126.GL17111@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160301115126.GL17111@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMDEsIDIwMTYgYXQgMTE6NTE6MjZBTSArMDAwMCwgV2VpIExpdSB3cm90ZToK PiBPbiBUaHUsIEZlYiAyNSwgMjAxNiBhdCAwMjo1NTo1OVBNICswMDAwLCBBbnRob255IFBFUkFS RCB3cm90ZToKPiA+IFRoaXMgcGF0Y2ggdXNlIHhjX2RvbV9hbGxvY19zZWdtZW50KCkgdG8gYWxs b2NhdGUgdGhlIG1lbW9yeSBzcGFjZSBmb3IgdGhlCj4gPiBBQ1BJIG1vZHVsZXMgYW5kIHRoZSBT TUJJT1MgbW9kdWxlcy4gVGhpcyBpcyB0byByZXBsYWNlIHRoZSBhcmJpdHJhcnkKPiA+IHBsYWNl bWVudCBvZiAxTUIgYWZ0ZXIgdGhlIGh2bWxvYWRlciBpbWFnZS4KPiA+IAo+ID4gSW4gbGF0ZXIg cGF0Y2hlcywgd2hpbGUgdHJ5aW5nIHRvIGxvYWQgYSBmaXJtd2FyZSBzdWNoIGFzIE9WTUYsIHRo ZSBsYXRlcgo+ID4gY291bGQgZWFzaWx5IGJlIGxvYWRlZCBwYXN0IHRoZSBhZGRyZXNzIDRNQiAo T1ZNRiBpcyBhIDJNQiBiaW5hcnkpLCBidXQKPiA+IGh2bWxvYWRlciB1c2UgYSByYW5nZSBvZiBt ZW1vcnkgZnJvbSA0TUIgdG8gOE1CIHRvIHBlcmZvcm0gdGVzdHMgYW5kIGluIHRoZQo+ID4gcHJv Y2VzcywgY2xlYXIgdGhlIG1lbW9yeSwgYmVmb3JlIGxvYWRpbmcgdGhlIG1vZHVsZXMuCj4gPiAK PiA+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXgu Y29tPgo+IAo+ID4gLS0tCj4gPiBOZXcgcGF0Y2ggaW4gVjMuCj4gPiAtLS0KPiA+ICB0b29scy9s aWJ4Yy94Y19kb21faHZtbG9hZGVyLmMgfCAxMjQgKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgOTMg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS90b29scy9saWJ4Yy94Y19kb21faHZt bG9hZGVyLmMgYi90b29scy9saWJ4Yy94Y19kb21faHZtbG9hZGVyLmMKPiA+IGluZGV4IDMzMGQ1 ZTguLjU0ZTA5NmMgMTAwNjQ0Cj4gPiAtLS0gYS90b29scy9saWJ4Yy94Y19kb21faHZtbG9hZGVy LmMKPiA+ICsrKyBiL3Rvb2xzL2xpYnhjL3hjX2RvbV9odm1sb2FkZXIuYwo+ID4gQEAgLTEyOSw5 OCArMTI5LDQ1IEBAIHN0YXRpYyBlbGZfZXJyb3JzdGF0dXMgeGNfZG9tX3BhcnNlX2h2bV9rZXJu ZWwoc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tKQo+ID4gICAgICByZXR1cm4gcmM7Cj4gPiAgfQo+ ID4gIAo+ID4gLXN0YXRpYyBpbnQgbW9kdWxlc19pbml0KHN0cnVjdCB4Y19kb21faW1hZ2UgKmRv bSwKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCB2ZW5kLCBzdHJ1Y3QgZWxm X2JpbmFyeSAqZWxmLAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ2NF90ICptc3Rh cnRfb3V0LCB1aW50NjRfdCAqbWVuZF9vdXQpCj4gPiArc3RhdGljIGludCBtb2R1bGVfaW5pdF9v bmUoc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgIHN0cnVjdCB4Y19odm1fZmlybXdhcmVfbW9kdWxlICptb2R1bGUsCj4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgY2hhciAqbmFtZSkKPiA+ICB7Cj4gPiAtI2RlZmluZSBNT0RVTEVf QUxJR04gMVVMIDw8IDcKPiA+IC0jZGVmaW5lIE1CX0FMSUdOICAgICAxVUwgPDwgMjAKPiA+IC0j ZGVmaW5lIE1LQUxJR04oeCwgYSkgKCgodWludDY0X3QpKHgpICsgKGEpIC0gMSkgJiB+KHVpbnQ2 NF90KSgoYSkgLSAxKSkKPiA+IC0gICAgdWludDY0X3QgdG90YWxfbGVuID0gMCwgb2Zmc2V0MSA9 IDA7Cj4gPiArICAgIHN0cnVjdCB4Y19kb21fc2VnIHNlZzsKPiA+ICsgICAgdm9pZCAqZGVzdDsK PiA+ICAKPiA+IC0gICAgaWYgKCBkb20tPmFjcGlfbW9kdWxlLmxlbmd0aCA9PSAwICYmIGRvbS0+ c21iaW9zX21vZHVsZS5sZW5ndGggPT0gMCApCj4gPiAtICAgICAgICByZXR1cm4gMDsKPiA+IC0K PiA+IC0gICAgLyogRmluZCB0aGUgdG90YWwgbGVuZ3RoIGZvciB0aGUgZmlybXdhcmUgbW9kdWxl cyB3aXRoIGEgcmVhc29uYWJsZSBsYXJnZQo+ID4gLSAgICAgKiBhbGlnbm1lbnQgc2l6ZSB0byBh bGlnbiBlYWNoIHRoZSBtb2R1bGVzLgo+ID4gLSAgICAgKi8KPiA+IC0gICAgdG90YWxfbGVuID0g TUtBTElHTihkb20tPmFjcGlfbW9kdWxlLmxlbmd0aCwgTU9EVUxFX0FMSUdOKTsKPiA+IC0gICAg b2Zmc2V0MSA9IHRvdGFsX2xlbjsKPiA+IC0gICAgdG90YWxfbGVuICs9IE1LQUxJR04oZG9tLT5z bWJpb3NfbW9kdWxlLmxlbmd0aCwgTU9EVUxFX0FMSUdOKTsKPiA+IC0KPiA+IC0gICAgLyogV2Fu dCB0byBwbGFjZSB0aGUgbW9kdWxlcyAxTWIrY2hhbmdlIGJlaGluZCB0aGUgbG9hZGVyIGltYWdl LiAqLwo+ID4gLSAgICAqbXN0YXJ0X291dCA9IE1LQUxJR04oZWxmLT5wZW5kLCBNQl9BTElHTikg KyAoTUJfQUxJR04pOwo+ID4gLSAgICAqbWVuZF9vdXQgPSAqbXN0YXJ0X291dCArIHRvdGFsX2xl bjsKPiA+IC0KPiA+IC0gICAgaWYgKCAqbWVuZF9vdXQgPiB2ZW5kICkKPiA+IC0gICAgICAgIHJl dHVybiAtMTsKPiA+IC0KPiA+IC0gICAgaWYgKCBkb20tPmFjcGlfbW9kdWxlLmxlbmd0aCAhPSAw ICkKPiA+IC0gICAgICAgIGRvbS0+YWNwaV9tb2R1bGUuZ3Vlc3RfYWRkcl9vdXQgPSAqbXN0YXJ0 X291dDsKPiA+IC0gICAgaWYgKCBkb20tPnNtYmlvc19tb2R1bGUubGVuZ3RoICE9IDAgKQo+ID4g LSAgICAgICAgZG9tLT5zbWJpb3NfbW9kdWxlLmd1ZXN0X2FkZHJfb3V0ID0gKm1zdGFydF9vdXQg KyBvZmZzZXQxOwo+ID4gKyAgICBpZiAoIG1vZHVsZS0+bGVuZ3RoICkKPiA+ICsgICAgewo+ID4g KyAgICAgICAgaWYgKCB4Y19kb21fYWxsb2Nfc2VnbWVudChkb20sICZzZWcsIG5hbWUsIDAsIG1v ZHVsZS0+bGVuZ3RoKSApCj4gPiArICAgICAgICAgICAgZ290byBlcnI7Cj4gPiArICAgICAgICBk ZXN0ID0geGNfZG9tX3NlZ190b19wdHIoZG9tLCAmc2VnKTsKPiA+ICsgICAgICAgIGlmICggZGVz dCA9PSBOVUxMICkKPiA+ICsgICAgICAgIHsKPiA+ICsgICAgICAgICAgICBET01QUklOVEYoIiVz OiB4Y19kb21fc2VnX3RvX3B0cihkb20sICZzZWcpID0+IE5VTEwiLAo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICBfX0ZVTkNUSU9OX18pOwo+ID4gKyAgICAgICAgICAgIGdvdG8gZXJyOwo+ID4g KyAgICAgICAgfQo+ID4gKyAgICAgICAgbWVtY3B5KGRlc3QsIG1vZHVsZS0+ZGF0YSwgbW9kdWxl LT5sZW5ndGgpOwo+ID4gKyAgICAgICAgbW9kdWxlLT5ndWVzdF9hZGRyX291dCA9IHNlZy52c3Rh cnQ7Cj4gCj4gT25lIHRoaW5nIHlvdSBtaWdodCB3YW50IHRvIHRha2UgY2FyZSBpcyB0aGF0IHRo ZSBndWVzdF9hZGRyX291dCBpcwo+IGFjdHVhbGx5IHdpdGhpbiBhIHJlYXNvbmFibGUgcmFuZ2Ug dGhhdCBodm1sb2FkZXIgY2FuIGFjY2Vzcz8KCkkgZ3Vlc3QgdGhhdCB3b3VsZCBiZSBhIGdvb2Qg aWRlZS4gU28gbWF5YmUgdGhleSBzaG91bGQgYmUgYmVsbG93IDNHQi4KCi0tIApBbnRob255IFBF UkFSRAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVu LWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMu eGVuLm9yZy94ZW4tZGV2ZWwK