From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753082AbcCGTLJ (ORCPT ); Mon, 7 Mar 2016 14:11:09 -0500 Received: from smtprelay0128.hostedemail.com ([216.40.44.128]:57921 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752855AbcCGTK7 (ORCPT ); Mon, 7 Mar 2016 14:10:59 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1537:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3865:3870:3871:3872:3874:5007:6119:6261:6742:7875:7903:10004:10400:10848:10967:11232:11658:11914:12517:12519:12740:13069:13311:13357:13439:14659:14721:21080:30012:30051:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:8,LUA_SUMMARY:none X-HE-Tag: jewel01_7c9c6ceecef50 X-Filterd-Recvd-Size: 2022 Date: Mon, 7 Mar 2016 14:10:55 -0500 From: Steven Rostedt To: Andy Lutomirski Cc: Jiri Kosina , Sedat Dilek , Alan Stern , Tejun Heo , Lai Jiangshan , Benjamin Tissoires , Paul McKenney , Andy Lutomirski , LKML , USB list , Greg Kroah-Hartman , Peter Zijlstra , Ingo Molnar Subject: Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning Message-ID: <20160307141055.506d0db7@gandalf.local.home> In-Reply-To: References: <20160307123020.7ca7a3ea@gandalf.local.home> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Mar 2016 10:04:21 -0800 Andy Lutomirski wrote: > > Exactly. The compiler may get away with this in userspace (maybe), but > > for the kernel, it is definitely a show stopper. Especially if it knows > > that an asm() may be called. > > It's broken for user code that fiddles with AC, too. Which is why I added the "(maybe)" ;-) -- Steve