From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753467AbcCGSsw (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Mar 2016 13:48:52 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40620 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752427AbcCGSso (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Mar 2016 13:48:44 -0500
Date: Mon, 7 Mar 2016 19:48:39 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: perf, tools: Refactor and support interval and CSV metrics
Message-ID: <20160307184839.GA15870@krava.redhat.com>
References: <1457049458-28956-1-git-send-email-andi@firstfloor.org>
 <20160307100842.GA28115@krava.redhat.com>
 <20160307182227.GC5083@two.firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160307182227.GC5083@two.firstfloor.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 07, 2016 at 07:22:27PM +0100, Andi Kleen wrote:
> On Mon, Mar 07, 2016 at 11:08:42AM +0100, Jiri Olsa wrote:
> > On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote:
> > 
> > SNIP
> > 
> > > 
> > > % perf stat -x, --metric-only  -a -I 1000
> > >      1.001381652,frontend cycles idle,insn per cycle,stalled cycles per insn,branch-misses of all branches,
> > >      1.001381652,173.32,0.83,2.09,1.73,
> > >      2.002073343,199.47,1.07,1.60,2.14,
> > >      3.002875524,109.52,0.22,7.83,1.63,
> > >      4.003970059,132.10,0.17,10.85,1.51,
> > >      5.004818754,181.60,0.22,8.87,2.22,
> > > 
> > > 
> > > Available in
> > > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 perf/stat-metrics-21
> > 
> > this branch contains old version of:
> >   perf, tools, stat: Add --metric-only support for -A
> 
> Old in what way? Looks correct to me.
> 
> 
> commit e26ba80593023c24c8276ad9853acd7e56ca92ed
> Author: Andi Kleen <ak@linux.intel.com>
> Date:   Sat Dec 19 11:22:55 2015 -0800
> 
>     perf, tools, stat: Add --metric-only support for -A
>     
>     Add metric only support for -A too. This requires a new print
>     function that prints the metrics in the right order.
>     
>     v2: Fix manpage
>     v3: Simplify nrcpus computation
>     Signed-off-by: Andi Kleen <ak@linux.intel.com>

I did not see the change for print_no_aggr_metric function
in commit:
   perf, tools, stat: Add --metric-only support for -A

which I saw in the email..

however now im confused, I did not noticed I had a wrong tree,
however git can't resolve the git tree you mentioned:

> Available in
> git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 perf/stat-metrics-21

	[jolsa@krava perf]$ git remote add ak1 git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 
	[jolsa@krava perf]$ git remote update ak1
	Fetching ak1
	fatal: remote error: access denied or repository not exported: /pub/scm/linux/kernel/git/ak/linux-misc-2.6
	error: Could not fetch ak1

so I guess the one I have is the correct one:
	git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc

however:
	[jolsa@krava perf]$ git remote update ak
	Fetching ak
	[jolsa@krava perf]$ git branch -r | grep stat-metrics-21
	[jolsa@krava perf]$

jirka