From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932578AbcCHJbP (ORCPT ); Tue, 8 Mar 2016 04:31:15 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:36363 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932290AbcCHJbK (ORCPT ); Tue, 8 Mar 2016 04:31:10 -0500 Date: Tue, 8 Mar 2016 18:32:30 +0900 From: Sergey Senozhatsky To: Vlastimil Babka Cc: Michal Hocko , Hugh Dickins , Sergey Senozhatsky , Andrew Morton , Linus Torvalds , Johannes Weiner , Mel Gorman , David Rientjes , Tetsuo Handa , Hillf Danton , KAMEZAWA Hiroyuki , linux-mm@kvack.org, LKML , Joonsoo Kim Subject: Re: [PATCH] mm, oom: protect !costly allocations some more Message-ID: <20160308093230.GB3860@swordfish> References: <1450203586-10959-1-git-send-email-mhocko@kernel.org> <20160203132718.GI6757@dhcp22.suse.cz> <20160225092315.GD17573@dhcp22.suse.cz> <20160229210213.GX16930@dhcp22.suse.cz> <20160307160838.GB5028@dhcp22.suse.cz> <56DE9A68.2010301@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56DE9A68.2010301@suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (03/08/16 10:24), Vlastimil Babka wrote: [..] > > @@ -3294,6 +3289,18 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > > did_some_progress > 0, no_progress_loops)) > > goto retry; > > > > + /* > > + * !costly allocations are really important and we have to make sure > > + * the compaction wasn't deferred or didn't bail out early due to locks > > + * contention before we go OOM. > > + */ > > + if (order && order <= PAGE_ALLOC_COSTLY_ORDER) { > > + if (compact_result <= COMPACT_CONTINUE) > > Same here. > I was going to say that this didn't have effect on Sergey's test, but > turns out it did :) I'm sorry, my test is not correct. I have disabled compaction last weeked on purpose - to provoke more OOM-kills and OOM conditions for reworked printk() patch set testing (http://marc.info/?l=linux-kernel&m=145734549308803); and I forgot to re-enable it. -ss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by kanga.kvack.org (Postfix) with ESMTP id 98B086B0005 for ; Tue, 8 Mar 2016 04:31:10 -0500 (EST) Received: by mail-pa0-f48.google.com with SMTP id fl4so8900876pad.0 for ; Tue, 08 Mar 2016 01:31:10 -0800 (PST) Received: from mail-pf0-x22d.google.com (mail-pf0-x22d.google.com. [2607:f8b0:400e:c00::22d]) by mx.google.com with ESMTPS id bw10si3531776pac.157.2016.03.08.01.31.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Mar 2016 01:31:09 -0800 (PST) Received: by mail-pf0-x22d.google.com with SMTP id x188so9017311pfb.2 for ; Tue, 08 Mar 2016 01:31:09 -0800 (PST) Date: Tue, 8 Mar 2016 18:32:30 +0900 From: Sergey Senozhatsky Subject: Re: [PATCH] mm, oom: protect !costly allocations some more Message-ID: <20160308093230.GB3860@swordfish> References: <1450203586-10959-1-git-send-email-mhocko@kernel.org> <20160203132718.GI6757@dhcp22.suse.cz> <20160225092315.GD17573@dhcp22.suse.cz> <20160229210213.GX16930@dhcp22.suse.cz> <20160307160838.GB5028@dhcp22.suse.cz> <56DE9A68.2010301@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56DE9A68.2010301@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: Michal Hocko , Hugh Dickins , Sergey Senozhatsky , Andrew Morton , Linus Torvalds , Johannes Weiner , Mel Gorman , David Rientjes , Tetsuo Handa , Hillf Danton , KAMEZAWA Hiroyuki , linux-mm@kvack.org, LKML , Joonsoo Kim On (03/08/16 10:24), Vlastimil Babka wrote: [..] > > @@ -3294,6 +3289,18 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > > did_some_progress > 0, no_progress_loops)) > > goto retry; > > > > + /* > > + * !costly allocations are really important and we have to make sure > > + * the compaction wasn't deferred or didn't bail out early due to locks > > + * contention before we go OOM. > > + */ > > + if (order && order <= PAGE_ALLOC_COSTLY_ORDER) { > > + if (compact_result <= COMPACT_CONTINUE) > > Same here. > I was going to say that this didn't have effect on Sergey's test, but > turns out it did :) I'm sorry, my test is not correct. I have disabled compaction last weeked on purpose - to provoke more OOM-kills and OOM conditions for reworked printk() patch set testing (http://marc.info/?l=linux-kernel&m=145734549308803); and I forgot to re-enable it. -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org