From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753194AbcCIKDk (ORCPT ); Wed, 9 Mar 2016 05:03:40 -0500 Received: from verein.lst.de ([213.95.11.211]:47381 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbcCIKDb (ORCPT ); Wed, 9 Mar 2016 05:03:31 -0500 Date: Wed, 9 Mar 2016 11:03:28 +0100 From: Torsten Duwe To: Petr Mladek Cc: Balbir Singh , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, kamalesh@linux.vnet.ibm.com, jeyu@redhat.com, jkosina@suse.cz, live-patching@vger.kernel.org, mbenes@suse.cz Subject: Re: [PATCH][v6][RFC] livepatch/ppc: Enable livepatching on powerpc Message-ID: <20160309100328.GB23039@lst.de> References: <1457506780-19556-1-git-send-email-bsingharora@gmail.com> <20160309091904.GA23039@lst.de> <20160309094423.GH10940@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160309094423.GH10940@pathway.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2016 at 10:44:23AM +0100, Petr Mladek wrote: > find a solution that would work transparently. I mean that adding > an extra hacks into selected functions in the patch might be quite > error prone and problems hard to debug. I think that we all want this > but I wanted to be sure :-) Full ACK. Again, the TOC restore needs to go _after_ the replacement function, and the klp_return_helper works as transparently as possible, so this was my first choice. Arguments on the stack? I thought we'll deal with them once we get there (e.g. _really_ need to patch a varargs function or one with a silly signature). Torsten