From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752694AbcCKMcU (ORCPT ); Fri, 11 Mar 2016 07:32:20 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33326 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbcCKMcM (ORCPT ); Fri, 11 Mar 2016 07:32:12 -0500 Date: Fri, 11 Mar 2016 13:32:09 +0100 From: Michal Hocko To: Vlastimil Babka Cc: LKML , Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , Christian =?iso-8859-1?Q?K=F6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Oleg Nesterov , Peter Zijlstra , Petr Cermak , Thomas Gleixner , Alexander Viro Subject: Re: [PATCH 03/18] mm: make vm_munmap killable Message-ID: <20160311123209.GJ27701@dhcp22.suse.cz> References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-4-git-send-email-mhocko@kernel.org> <56E298B1.6010802@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E298B1.6010802@suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 11-03-16 11:06:41, Vlastimil Babka wrote: > On 02/29/2016 02:26 PM, Michal Hocko wrote: > >From: Michal Hocko > > > >Almost all current users of vm_munmap are ignoring the return value > >and so they do not handle potential error. This means that some VMAs > > 1 7834 arch/x86/kvm/x86.c <<__x86_set_memory_region>> > > r = vm_munmap(old.userspace_addr, old.npages * PAGE_SIZE); > WARN_ON(r < 0); > > This warning will potentially add noise to OOM output? Would it be harmfull though? I mean the warning is just goofy. I can make it not warn on (r < 0 && r != -EINTR) but is it worth bothering? Thanks! -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH 03/18] mm: make vm_munmap killable Date: Fri, 11 Mar 2016 13:32:09 +0100 Message-ID: <20160311123209.GJ27701@dhcp22.suse.cz> References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-4-git-send-email-mhocko@kernel.org> <56E298B1.6010802@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:33326 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbcCKMcM (ORCPT ); Fri, 11 Mar 2016 07:32:12 -0500 Content-Disposition: inline In-Reply-To: <56E298B1.6010802@suse.cz> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Vlastimil Babka Cc: LKML , Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , Christian =?iso-8859-1?Q?K=F6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Oleg Nesterov Pe On Fri 11-03-16 11:06:41, Vlastimil Babka wrote: > On 02/29/2016 02:26 PM, Michal Hocko wrote: > >From: Michal Hocko > > > >Almost all current users of vm_munmap are ignoring the return value > >and so they do not handle potential error. This means that some VMAs > > 1 7834 arch/x86/kvm/x86.c <<__x86_set_memory_region>> > > r = vm_munmap(old.userspace_addr, old.npages * PAGE_SIZE); > WARN_ON(r < 0); > > This warning will potentially add noise to OOM output? Would it be harmfull though? I mean the warning is just goofy. I can make it not warn on (r < 0 && r != -EINTR) but is it worth bothering? Thanks! -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by kanga.kvack.org (Postfix) with ESMTP id CE9686B0253 for ; Fri, 11 Mar 2016 07:32:11 -0500 (EST) Received: by mail-wm0-f43.google.com with SMTP id p65so16135206wmp.1 for ; Fri, 11 Mar 2016 04:32:11 -0800 (PST) Date: Fri, 11 Mar 2016 13:32:09 +0100 From: Michal Hocko Subject: Re: [PATCH 03/18] mm: make vm_munmap killable Message-ID: <20160311123209.GJ27701@dhcp22.suse.cz> References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-4-git-send-email-mhocko@kernel.org> <56E298B1.6010802@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E298B1.6010802@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: LKML , Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , Christian =?iso-8859-1?Q?K=F6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Oleg Nesterov , Peter Zijlstra , Petr Cermak , Thomas Gleixner , Alexander Viro On Fri 11-03-16 11:06:41, Vlastimil Babka wrote: > On 02/29/2016 02:26 PM, Michal Hocko wrote: > >From: Michal Hocko > > > >Almost all current users of vm_munmap are ignoring the return value > >and so they do not handle potential error. This means that some VMAs > > 1 7834 arch/x86/kvm/x86.c <<__x86_set_memory_region>> > > r = vm_munmap(old.userspace_addr, old.npages * PAGE_SIZE); > WARN_ON(r < 0); > > This warning will potentially add noise to OOM output? Would it be harmfull though? I mean the warning is just goofy. I can make it not warn on (r < 0 && r != -EINTR) but is it worth bothering? Thanks! -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org