From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932823AbcCKPmO (ORCPT ); Fri, 11 Mar 2016 10:42:14 -0500 Received: from mail.skyhub.de ([78.46.96.112]:41746 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932694AbcCKPmK (ORCPT ); Fri, 11 Mar 2016 10:42:10 -0500 Date: Fri, 11 Mar 2016 16:41:45 +0100 From: Borislav Petkov To: Peter Zijlstra Cc: Vince Weaver , mingo@kernel.org, alexander.shishkin@linux.intel.com, eranian@google.com, linux-kernel@vger.kernel.org, dvyukov@google.com, andi@firstfloor.org, jolsa@redhat.com, panand@redhat.com, sasha.levin@oracle.com, oleg@redhat.com Subject: Re: [PATCH 00/12] perf: more fixes Message-ID: <20160311154145.GE4312@pd.tnic> References: <20160224174539.570749654@infradead.org> <20160310143924.GR6356@twins.programming.kicks-ass.net> <20160311142346.GE6344@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160311142346.GE6344@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 11, 2016 at 03:23:46PM +0100, Peter Zijlstra wrote: > The below seems to fix the IBS issue tickled by syz-kaller on my > machine. I've not yet ran perf-fuzzer, which seems able to tickle a > different set of bugs. > > --- > Subject: perf, amb: Fix IBS throttle amd but you know already. > > When the IBS IRQ handler get a !0 return from perf_event_overflow; > meaning it should throttle the event, it only disables it, it doesn't > call perf_ibs_stop(). > > This confuses the state machine, as we'll use pmu::start() -> > perf_ibs_start() to unthrottle. > > Signed-off-by: Peter Zijlstra (Intel) Tested-by: Borislav Petkov I'll leave it running for an additional hour but if I haven't said anything until then, all is good. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.