From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [198.137.202.9] ([198.137.202.9]:56679 "EHLO bombadil.infradead.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752147AbcCOHeu (ORCPT ); Tue, 15 Mar 2016 03:34:50 -0400 Date: Tue, 15 Mar 2016 00:33:59 -0700 From: Christoph Hellwig To: Bob Peterson Cc: linux-fsdevel@vger.kernel.org, Jan Kara , Al Viro , Dave Chinner , Christoph Hellwig Subject: Re: [vfs PATCH v3 4/4] GFS2: Use new iomap interface for fiemap Message-ID: <20160315073359.GG11669@infradead.org> References: <1457122300-28514-1-git-send-email-rpeterso@redhat.com> <1457122300-28514-5-git-send-email-rpeterso@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457122300-28514-5-git-send-email-rpeterso@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > - ret = __generic_block_fiemap(inode, fieinfo, start, len, > - gfs2_block_map); > + ret = __generic_iomap_fiemap(inode, fieinfo, start, len, > + gfs2_get_iomap); So it seems like the generic_iomap_fiemap you added is unused, no need to add it then.