From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934004AbcCOHf4 (ORCPT ); Tue, 15 Mar 2016 03:35:56 -0400 Received: from [198.137.202.9] ([198.137.202.9]:56963 "EHLO bombadil.infradead.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752147AbcCOHfp (ORCPT ); Tue, 15 Mar 2016 03:35:45 -0400 Date: Tue, 15 Mar 2016 00:34:55 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: axboe@kernel.dk, torvalds@linux-foundation.org, hch@infradead.org, tytso@mit.edu, martin.petersen@oracle.com, linux-api@vger.kernel.org, david@fromorbit.com, linux-kernel@vger.kernel.org, shane.seymour@hpe.com, bfields@fieldses.org, linux-fsdevel@vger.kernel.org, jlayton@poochiereds.net, akpm@linux-foundation.org Subject: Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size Message-ID: <20160315073455.GH11669@infradead.org> References: <20160305005556.29738.66782.stgit@birch.djwong.org> <20160305005610.29738.18727.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160305005610.29738.18727.stgit@birch.djwong.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 04, 2016 at 04:56:10PM -0800, Darrick J. Wong wrote: > Make sure that the offset and length arguments that we're using to > construct WRITE SAME and DISCARD requests are actually aligned to the > logical block size. Failure to do this causes other errors in other > parts of the block layer or the SCSI layer because disks don't support > partial logical block writes. Looks fine, Reviewed-by: Christoph Hellwig