From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afjEE-0002lj-NP for qemu-devel@nongnu.org; Tue, 15 Mar 2016 03:17:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afjE9-0004ZJ-Nw for qemu-devel@nongnu.org; Tue, 15 Mar 2016 03:17:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afjE9-0004ZA-Hq for qemu-devel@nongnu.org; Tue, 15 Mar 2016 03:17:13 -0400 Date: Tue, 15 Mar 2016 09:17:10 +0200 From: "Michael S. Tsirkin" Message-ID: <20160315091411-mutt-send-email-mst@redhat.com> References: <1457974531-8768-1-git-send-email-minyard@acm.org> <20160315085654-mutt-send-email-mst@redhat.com> <1458025488.13231.20.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458025488.13231.20.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Paolo Bonzini , qemu-devel@nongnu.org, minyard@acm.org, Corey Minyard On Tue, Mar 15, 2016 at 08:04:48AM +0100, Gerd Hoffmann wrote: > Hi, > > > > Don't add a new machine type in this version, just use the 2.6 one. > > > > Unfortunately this patch won't help any, as your next patch reorders fw > > cfg files which will affect the old machine types. > > We can make that depend on dont_sort_fw_cfgs too, to keep things as-is > on old machine types. Yes, except the name is a bit off then. It's more "legacy_fw_cfg_order" than "dont_sort_fw_cfgs". > Which probably implies only new machine types > will see the new smbios entries. > > cheers, > Gerd Not really I think. If there's a new device triggering a new smbios entry, we don't care how it's sorted since by then there's no question of cross-version migration with old QEMU. -- MST