From: Chris Wilson <chris@chris-wilson.co.uk>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915: Add fault injection support
Date: Tue, 15 Mar 2016 09:28:34 +0000 [thread overview]
Message-ID: <20160315092834.GT14143@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1458030842.7272.4.camel@linux.intel.com>
On Tue, Mar 15, 2016 at 10:34:02AM +0200, Joonas Lahtinen wrote:
> On ma, 2016-03-14 at 16:59 +0200, Imre Deak wrote:
> > +module_param_named(inject_load_failure, i915.inject_load_failure,
> > uint, 0600);
>
> This most definitely should be module_param_named_unsafe.
>
> I think I'd also hope to see some kind of compile time option to enable
> this. I don't think average user wants this by default.
That's not a bad idea. We can get rid of most of the dangerous params
this way. On the other hand, we need to keep the debug/quirk params
around so that we can test options in the wild (bug reporters).
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-15 9:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 23:15 [PATCH] drm/i915: Add fault injection support Imre Deak
2016-03-12 7:40 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-14 9:20 ` [PATCH v2] " Imre Deak
2016-03-14 14:59 ` [PATCH v3] " Imre Deak
2016-03-15 8:34 ` Joonas Lahtinen
2016-03-15 9:28 ` Chris Wilson [this message]
2016-03-15 13:17 ` Daniel Vetter
2016-03-15 14:08 ` Imre Deak
2016-03-15 8:56 ` Daniel Vetter
2016-03-15 14:01 ` Imre Deak
2016-03-15 14:14 ` Chris Wilson
2016-03-16 9:18 ` Joonas Lahtinen
2016-03-16 9:24 ` Chris Wilson
2016-03-16 9:43 ` Imre Deak
2016-03-16 10:04 ` Chris Wilson
2016-03-16 10:17 ` Imre Deak
2016-03-16 10:26 ` Chris Wilson
2016-03-14 10:40 ` ✗ Fi.CI.BAT: failure for drm/i915: Add fault injection support (rev2) Patchwork
2016-03-14 14:40 ` ✗ Fi.CI.BAT: failure for drm/i915: Add fault injection support (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315092834.GT14143@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.