From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ag06b-00059E-8B for qemu-devel@nongnu.org; Tue, 15 Mar 2016 21:18:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ag06Z-000703-TE for qemu-devel@nongnu.org; Tue, 15 Mar 2016 21:18:33 -0400 Date: Wed, 16 Mar 2016 12:06:39 +1100 From: David Gibson Message-ID: <20160316010639.GR9032@voom> References: <1457974600-13828-1-git-send-email-clg@fr.ibm.com> <1457974600-13828-9-git-send-email-clg@fr.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1GSL5ZULXUIqbbH1" Content-Disposition: inline In-Reply-To: <1457974600-13828-9-git-send-email-clg@fr.ibm.com> Subject: Re: [Qemu-devel] [PATCH 08/17] ppc: Add placeholder SPRs for DPDES and DHDES on P8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Thomas Huth , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --1GSL5ZULXUIqbbH1 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 14, 2016 at 05:56:31PM +0100, C=E9dric Le Goater wrote: > From: Benjamin Herrenschmidt >=20 > We still need to eventually implement doorbells but at least this > makes us not crash when the SPRs are accessed. >=20 > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson But expecting this will be for 2.7, not 2.6. > --- > target-ppc/cpu.h | 2 ++ > target-ppc/translate_init.c | 17 +++++++++++++++++ > 2 files changed, 19 insertions(+) >=20 > diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h > index 02aed6427ade..779cb57bd700 100644 > --- a/target-ppc/cpu.h > +++ b/target-ppc/cpu.h > @@ -1394,6 +1394,8 @@ static inline int cpu_mmu_index (CPUPPCState *env, = bool ifetch) > #define SPR_MPC_ICTRL (0x09E) > #define SPR_MPC_BAR (0x09F) > #define SPR_PSPB (0x09F) > +#define SPR_DHDES (0x0B1) > +#define SPR_DPDES (0x0B0) > #define SPR_DAWR (0x0B4) > #define SPR_RPR (0x0BA) > #define SPR_DAWRX (0x0BC) > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 59a68de0bce8..7a399b97bc6f 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -8036,6 +8036,22 @@ static void gen_spr_power8_rpr(CPUPPCState *env) > #endif > } > =20 > +static void gen_spr_power8_dbell(CPUPPCState *env) > +{ > +#if !defined(CONFIG_USER_ONLY) > + spr_register_hv(env, SPR_DPDES, "DPDES", > + SPR_NOACCESS, SPR_NOACCESS, > + &spr_read_generic, SPR_NOACCESS, > + &spr_read_generic, &spr_write_generic, > + 0); > + spr_register_hv(env, SPR_DHDES, "DHDES", > + SPR_NOACCESS, SPR_NOACCESS, > + SPR_NOACCESS, SPR_NOACCESS, > + &spr_read_generic, &spr_write_generic, > + 0); > +#endif > +} > + > static void init_proc_book3s_64(CPUPPCState *env, int version) > { > gen_spr_ne_601(env); > @@ -8089,6 +8105,7 @@ static void init_proc_book3s_64(CPUPPCState *env, i= nt version) > gen_spr_power8_pspb(env); > gen_spr_vtb(env); > gen_spr_power8_rpr(env); > + gen_spr_power8_dbell(env); > } > if (version < BOOK3S_CPU_POWER8) { > gen_spr_book3s_dbg(env); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --1GSL5ZULXUIqbbH1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW6LGfAAoJEGw4ysog2bOS2z4P/0RJNSHMEx3a9AnKdw/4nJ+3 EsJeWV13pqpCv+VmM3n/r/NN2byZtyJZPJzmfDSlGLtDwTmsaqrAZyrS1d24KSh9 H4/DyDkV5StAhXoTifK1HIGp3JzyFx1DnV+IC6cEzjN6JnsO4WyJ6o02zJ+i2wEA wXvamGkrkG+s4uCMscDRVsB810f/xdyho8sfAY//Wy2fzqZiRJtzQUradnxOys/a G9yqDcT8lCc3EI3jY/9q8Y2/s/WYyYWxUsgp1QTeOxmzshFB3RipwWAgH3xl9et8 CTImwM+u85ZWKlJmWV0MVg5xwPAN/FBDqoCsAj5Oovwd3l5hFzOf6uL1sUrRTcRF WV+a9sLq6BmQHDG9mhhh85B8pxbpfiojy5qYMEMrzgcATxP7mzj/xrD3gJNDo4U5 P+wIWnKSQGX74jZ4ifQaE2LaE5cDj3BEe9sSU/wrXoCwwQPC58KQOzPleAzdvTpY Vsj9wcu+7fA7FTrSZp1IlZCYgeTfnt6cc5vjZh3n8I/GSMTPlDP+2l9EJX2G+pYT PST/n3+JlIZafoCTGqZBUlnzbTviDT7TjVflpbchguXJmIXNj8skwK15deL//gUz wYYmV8hlh9Pur6WHNn9HDGTxf8/Dt9wCslmYBsKq36Kh/JDeNUHSCgUtym0HGMmz /Mhr/xz8NDI5r+limNx2 =BRxA -----END PGP SIGNATURE----- --1GSL5ZULXUIqbbH1--