From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ag06c-00059g-Dm for qemu-devel@nongnu.org; Tue, 15 Mar 2016 21:18:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ag06b-00071V-Ar for qemu-devel@nongnu.org; Tue, 15 Mar 2016 21:18:34 -0400 Date: Wed, 16 Mar 2016 12:07:20 +1100 From: David Gibson Message-ID: <20160316010720.GS9032@voom> References: <1457974600-13828-1-git-send-email-clg@fr.ibm.com> <1457974600-13828-10-git-send-email-clg@fr.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="daC8KDjlMyCcZyAo" Content-Disposition: inline In-Reply-To: <1457974600-13828-10-git-send-email-clg@fr.ibm.com> Subject: Re: [Qemu-devel] [PATCH 09/17] ppc: SPURR & PURR are HV writeable and privileged List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Thomas Huth , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --daC8KDjlMyCcZyAo Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 14, 2016 at 05:56:32PM +0100, C=E9dric Le Goater wrote: > From: Benjamin Herrenschmidt >=20 > Those are HV writeable, so we provide a dummy write. We eventually need > to provide a better emulation but for now this will get us going. >=20 > We also make them non-user readable as per the architecture. >=20 > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson But expecting it for 2.7, not 2.6. > --- > target-ppc/translate_init.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) >=20 > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 7a399b97bc6f..10f67136b609 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -293,6 +293,13 @@ static void spr_read_purr (DisasContext *ctx, int gp= rn, int sprn) > { > gen_helper_load_purr(cpu_gpr[gprn], cpu_env); > } > + > +__attribute__ ((unused)) > +static void spr_write_purr(DisasContext *ctx, int gprn, int sprn) > +{ > + /* Temporary placeholder */ > +} > + > #endif > #endif > =20 > @@ -7828,14 +7835,16 @@ static void gen_spr_book3s_purr(CPUPPCState *env) > { > #if !defined(CONFIG_USER_ONLY) > /* PURR & SPURR: Hack - treat these as aliases for the TB for now */ > - spr_register_kvm(env, SPR_PURR, "PURR", > - &spr_read_purr, SPR_NOACCESS, > - &spr_read_purr, SPR_NOACCESS, > - KVM_REG_PPC_PURR, 0x00000000); > - spr_register_kvm(env, SPR_SPURR, "SPURR", > - &spr_read_purr, SPR_NOACCESS, > - &spr_read_purr, SPR_NOACCESS, > - KVM_REG_PPC_SPURR, 0x00000000); > + spr_register_kvm_hv(env, SPR_PURR, "PURR", > + SPR_NOACCESS, SPR_NOACCESS, > + &spr_read_purr, SPR_NOACCESS, > + &spr_read_purr, &spr_write_purr, > + KVM_REG_PPC_PURR, 0x00000000); > + spr_register_kvm_hv(env, SPR_SPURR, "SPURR", > + SPR_NOACCESS, SPR_NOACCESS, > + &spr_read_purr, SPR_NOACCESS, > + &spr_read_purr, &spr_write_purr, > + KVM_REG_PPC_SPURR, 0x00000000); > #endif > } > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --daC8KDjlMyCcZyAo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW6LHIAAoJEGw4ysog2bOSFGUP/3Kna6ykPdAFnsXBomF93RFv BqL94gQYLJaxpE2Em9tG0YesOmY3Y8EyplyWXmmc/GVGymtp3GwQ/zSqb1KYn1G7 xCm8ZA/avxO0601mYvUq3a/TpGVJqcR2aCoyu9JrnA0VAMurcg8SfehbYT7Jk85O A6n+FpQL3ikxCu8KNu8g6v7jPoDMU/z9IPK2iEwuoKS11GfB36ARaxRab97hgr+4 NfhyBIjirek5OFFOSTHJmKLZyM+KnsOuGQhEvRzmN2ZDS/UruhgJO5wlxs7EOYse BYi9eDWHcBkcqtXhP1ofizNMhQWY9LPZYoI5ykm/Ita2vQ18S+Ce4aC1zLgQizTP ZO21DNxLFpifROYIkjRmEZJQ+Hel8VwXVZSLzDxcEk60eSao94omCIH4xCGrrfuo HV/1m5swE+1fh82sviRvySWnyE5zKTuojLVHVHQ4jyqFCTCvMPYodnE1anh9LGys lBIWQU7+4uZpU1KDqK7AbbV+N7FQOcZRLRyGQh4sASebOczqOZa5wKbiyJX0y6B5 /Z/9IWQVOK36MoF481FEI+Rbm1u/Xi4+5/lygMbd8KM9TClI5fVVh39wpOPHftR/ 4pQOM6ycONLA5HdJPQeRayBRHkCjOpQ7qCXUW/lojlvixh5rZiVn0v8lSeSGr9uc iwlB4UhamFQlzdWRmUYr =fOaq -----END PGP SIGNATURE----- --daC8KDjlMyCcZyAo--