All of lore.kernel.org
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the rdma tree
@ 2016-03-16  1:15 Stephen Rothwell
  2016-03-16  6:49 ` Herbert Xu
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2016-03-16  1:15 UTC (permalink / raw)
  To: Doug Ledford, Herbert Xu; +Cc: linux-next, linux-kernel, Faisal Latif

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/infiniband/hw/i40iw/i40iw.h:57:0,
                 from drivers/infiniband/hw/i40iw/i40iw_cm.c:63:
drivers/infiniband/hw/i40iw/i40iw_osdep.h:175:12: warning: 'struct hash_desc' declared inside parameter list
            u32 length, u32 value);
            ^

And it went downhill badly after that.

Caused by commit

  896545098777 ("crypto: hash - Remove crypto_hash interface")

from the crypto tree interacting with commits

  786c6adb3a94 ("i40iw: add puda code")
  4e9042e647ff ("i40iw: add hw and utils files")

(at least) from the rdma tree.

Its a bit of a pain finding these conflicts now - it would have been
better a few weeks ago.

For now, all I can do is to use the rdma tree from next-20160315 for
today.

Herbert, any hints for Doug, Faisal?

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2020-02-26  2:51 Stephen Rothwell
  2020-02-26  3:04 ` Devesh Sharma
  2020-02-26 17:25 ` Jason Gunthorpe
  0 siblings, 2 replies; 68+ messages in thread
From: Stephen Rothwell @ 2020-02-26  2:51 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Devesh Sharma, Naresh Kumar PBS, Selvin Xavier

[-- Attachment #1: Type: text/plain, Size: 2315 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/infiniband/hw/bnxt_re/qplib_res.c: In function '__free_pbl':
drivers/infiniband/hw/bnxt_re/qplib_res.c:78:2: error: implicit declaration of function 'vfree'; did you mean 'kfree'? [-Werror=implicit-function-declaration]
   78 |  vfree(pbl->pg_arr);
      |  ^~~~~
      |  kfree
drivers/infiniband/hw/bnxt_re/qplib_res.c: In function '__alloc_pbl':
drivers/infiniband/hw/bnxt_re/qplib_res.c:117:16: error: implicit declaration of function 'vmalloc'; did you mean 'kmalloc'? [-Werror=implicit-function-declaration]
  117 |  pbl->pg_arr = vmalloc(pages * sizeof(void *));
      |                ^~~~~~~
      |                kmalloc
drivers/infiniband/hw/bnxt_re/qplib_res.c:117:14: warning: assignment to 'void **' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  117 |  pbl->pg_arr = vmalloc(pages * sizeof(void *));
      |              ^
drivers/infiniband/hw/bnxt_re/qplib_res.c:121:18: warning: assignment to 'dma_addr_t *' {aka 'long long unsigned int *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
  121 |  pbl->pg_map_arr = vmalloc(pages * sizeof(dma_addr_t));
      |                  ^

Caused by commit

  0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation")

I added the following fix for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 26 Feb 2020 13:46:02 +1100
Subject: [PATCH] RDMA/bnxt_re: using vmalloc requires including vmalloc.h

Fixes: 0c4dcd602817 ("RDMA/bnxt_re: Refactor hardware queue memory allocation")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/infiniband/hw/bnxt_re/qplib_res.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
index 4346b95963cf..fc5909c7f2e0 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
@@ -44,6 +44,7 @@
 #include <linux/inetdevice.h>
 #include <linux/dma-mapping.h>
 #include <linux/if_vlan.h>
+#include <linux/vmalloc.h>
 #include "roce_hsi.h"
 #include "qplib_res.h"
 #include "qplib_sp.h"
-- 
2.25.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2019-07-09  3:30 Stephen Rothwell
  2019-07-09  7:04 ` Mark Zhang
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-09  3:30 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Mark Zhang,
	Majd Dibbiny, asahiro Yamada

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from /home/sfr/next/next/include/rdma/rdma_counter.h:12,
                 from <command-line>:
/home/sfr/next/next/include/rdma/ib_verbs.h:2126:27: error: field 'port_counter' has incomplete type
  struct rdma_port_counter port_counter;
                           ^~~~~~~~~~~~

Caused by commit

  413d3347503b ("RDMA/counter: Add set/clear per-port auto mode support")

rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
from rdma_counter.h, but it is not defined yet :-(

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 9 Jul 2019 13:17:49 +1000
Subject: [PATCH] RDMA: don't try to build rdma_counter.h for now

rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
from rdma_counter.h, but it is not defined yet :-(

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/Kbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/Kbuild b/include/Kbuild
index 78434c59701f..8dab85cdf4f4 100644
--- a/include/Kbuild
+++ b/include/Kbuild
@@ -939,6 +939,7 @@ header-test-			+= rdma/ib.h
 header-test-			+= rdma/iw_portmap.h
 header-test-			+= rdma/opa_port_info.h
 header-test-			+= rdma/rdmavt_cq.h
+header-test-			+= rdma/rdma_counter.h
 header-test-			+= rdma/restrack.h
 header-test-			+= rdma/signature.h
 header-test-			+= rdma/tid_rdma_defs.h
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2019-07-08  3:03 Stephen Rothwell
  2019-07-08 14:09 ` Jason Gunthorpe
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-08  3:03 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Bernard Metzler

[-- Attachment #1: Type: text/plain, Size: 4144 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/asm-generic/percpu.h:7,
                 from arch/x86/include/asm/percpu.h:544,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:78,
                 from include/linux/spinlock.h:51,
                 from include/linux/seqlock.h:36,
                 from include/linux/time.h:6,
                 from include/linux/ktime.h:24,
                 from include/linux/timer.h:6,
                 from include/linux/netdevice.h:24,
                 from drivers/infiniband/sw/siw/siw_main.c:8:
include/linux/percpu-defs.h:92:33: warning: '__pcpu_unique_use_cnt' initialized and declared 'extern'
  extern __PCPU_DUMMY_ATTRS char __pcpu_unique_##name;  \
                                 ^~~~~~~~~~~~~~
include/linux/percpu-defs.h:115:2: note: in expansion of macro 'DEFINE_PER_CPU_SECTION'
  DEFINE_PER_CPU_SECTION(type, name, "")
  ^~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~
include/linux/percpu-defs.h:93:26: error: redefinition of '__pcpu_unique_use_cnt'
  __PCPU_DUMMY_ATTRS char __pcpu_unique_##name;   \
                          ^~~~~~~~~~~~~~
include/linux/percpu-defs.h:115:2: note: in expansion of macro 'DEFINE_PER_CPU_SECTION'
  DEFINE_PER_CPU_SECTION(type, name, "")
  ^~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~
include/linux/percpu-defs.h:92:33: note: previous definition of '__pcpu_unique_use_cnt' was here
  extern __PCPU_DUMMY_ATTRS char __pcpu_unique_##name;  \
                                 ^~~~~~~~~~~~~~
include/linux/percpu-defs.h:115:2: note: in expansion of macro 'DEFINE_PER_CPU_SECTION'
  DEFINE_PER_CPU_SECTION(type, name, "")
  ^~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:33: warning: 'use_cnt' initialized and declared 'extern'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
                                 ^~~~~~~
include/linux/percpu-defs.h:94:44: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
  extern __PCPU_ATTRS(sec) __typeof__(type) name;   \
                                            ^~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:33: error: redefinition of 'use_cnt'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
                                 ^~~~~~~
include/linux/percpu-defs.h:95:44: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
  __PCPU_ATTRS(sec) __weak __typeof__(type) name
                                            ^~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~
drivers/infiniband/sw/siw/siw_main.c:129:33: note: previous definition of 'use_cnt' was here
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
                                 ^~~~~~~
include/linux/percpu-defs.h:94:44: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
  extern __PCPU_ATTRS(sec) __typeof__(type) name;   \
                                            ^~~~
drivers/infiniband/sw/siw/siw_main.c:129:8: note: in expansion of macro 'DEFINE_PER_CPU'
 static DEFINE_PER_CPU(atomic_t, use_cnt = ATOMIC_INIT(0));
        ^~~~~~~~~~~~~~

Caused by commit

  bdcf26bf9b3a ("rdma/siw: network and RDMA core interface")

I have used the rdma tree from 20190628 again today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2019-07-08  2:57 Stephen Rothwell
  2019-07-08 16:08 ` Jason Gunthorpe
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-08  2:57 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe, Masahiro Yamada
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Kamenee Arumugam, Dennis Dalessandro

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from <command-line>:32:
./usr/include/rdma/rvt-abi.h:13:10: fatal error: rdma/ib_verbs.h: No such file or directory
 #include <rdma/ib_verbs.h>
          ^~~~~~~~~~~~~~~~~

Caused by commits

  dabac6e460ce ("IB/hfi1: Move receive work queue struct into uapi directory")

interacting with commit

  0c422a3d4e1b ("kbuild: compile-test exported headers to ensure they are self-contained")

from the kbuild tree.

You can't reference the include/linux headers from uapi headers ...

I have used the rmda tree from 20190628 again today (given the previous
errors).
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2019-07-01  4:14 Stephen Rothwell
  2019-07-01  7:54 ` wangxi
  2019-07-04  2:02 ` Stephen Rothwell
  0 siblings, 2 replies; 68+ messages in thread
From: Stephen Rothwell @ 2019-07-01  4:14 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Xi Wang, Lijun Ou

[-- Attachment #1: Type: text/plain, Size: 15626 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_ah.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_alloc.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_cmd.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_cq.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_db.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_hem.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_mr.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_pd.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_qp.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_restrack.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/infiniband/hw/hns/hns_roce_srq.o
see include/linux/module.h for more information
ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_ib_umem_write_mtt" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_mtt_cleanup" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_buf_write_mtt" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_buf_alloc" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_mtt_init" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns_roce_srq.ko] undefined!
ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_free_db" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_alloc_db" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_bitmap_free_range" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_bitmap_alloc_range" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_db_unmap_user" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_mtr_cleanup" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_get_kmem_bufs" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_buf_alloc" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_db_map_user" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_free_buf_list" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_mtr_attach" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_mtr_init" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_hem_list_calc_root_ba" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_get_umem_bufs" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_alloc_buf_list" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_init_buf_region" [drivers/infiniband/hw/hns/hns_roce_qp.ko] undefined!
ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_pd.ko] undefined!
ERROR: "hns_roce_hem_list_find_mtt" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_hem_list_request" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_hem_list_release" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_hem_list_init" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_check_whether_mhop" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_table_put_range" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_table_get_range" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_mr.ko] undefined!
ERROR: "hns_roce_fill_res_entry" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_dereg_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_reg_user_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_get_dma_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_ib_create_cq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_modify_qp" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_create_qp" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_destroy_ah" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_query_ah" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_create_ah" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_dealloc_pd" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_alloc_pd" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_rereg_user_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_dealloc_mw" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_alloc_mw" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_map_mr_sg" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_alloc_mr" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_destroy_srq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_create_srq" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_qp_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_uar_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_pd_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_mr_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_cq_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_hem_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cmd_use_polling" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_srq_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cmd_cleanup" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_hem" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cleanup_bitmap" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cmd_use_events" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_qp_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_cq_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_mr_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_pd_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_uar_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_check_whether_mhop" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_init_hem_table" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_cmd_init" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_uar_alloc" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_uar_free" [drivers/infiniband/hw/hns/hns_roce_main.ko] undefined!
ERROR: "hns_roce_bitmap_cleanup" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_bitmap_init" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_free_db" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_db_unmap_user" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_mtt_cleanup" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_ib_umem_write_mtt" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_db_map_user" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_buf_write_mtt" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_buf_alloc" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_alloc_db" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_mtt_init" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_table_get" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_bitmap_alloc" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_check_whether_mhop" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_table_put" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns_roce_cq.ko] undefined!
ERROR: "hns_roce_cleanup_srq_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "hns_roce_cleanup_uar_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "hns_roce_cleanup_pd_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "hns_roce_cleanup_mr_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "hns_roce_cleanup_cq_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "hns_roce_cleanup_qp_table" [drivers/infiniband/hw/hns/hns_roce_alloc.ko] undefined!
ERROR: "to_hr_qp_type" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "get_send_wqe" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_release_range_qp" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_mtt_cleanup" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_cmd_mbox" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_cmd_event" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_cq_completion" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_create_qp" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_init" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_buf_free" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_free_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_hw2sw_mpt" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_get_gid_index" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_dealloc_pd" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_alloc_cmd_mailbox" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_qp_remove" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_alloc_pd" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_free_cmd_mailbox" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "get_recv_wqe" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_unlock_cqs" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_exit" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_qp_event" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_table_find" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "to_hns_roce_state" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_ib_create_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_cq_event" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_qp_free" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_lock_cqs" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_wq_overflow" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "key_to_hw_index" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_bitmap_free" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!
ERROR: "hns_roce_ib_destroy_cq" [drivers/infiniband/hw/hns/hns-roce-hw-v1.ko] undefined!

Presumably caused by commit

  e9816ddf2a33 ("RDMA/hns: Cleanup unnecessary exported symbols")

I have used the rdma tree from next-20190628 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2018-12-04  0:47 Stephen Rothwell
  2018-12-04  1:52 ` Jason Gunthorpe
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2018-12-04  0:47 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Guy Levi,
	Majd Dibbiny, Leon Romanovsky

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "mlx5_get_send_wqe" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined!

Caused by commit

  34f4c9554d8b ("IB/mlx5: Use fragmented QP's buffer for in-kernel users")

mlx5_get_send_wqe() is still used in drivers/infiniband/hw/mlx5/cq.c
and declared in drivers/infiniband/hw/mlx5/mlx5_ib.h ...

I have used the version of the rdma tree from next-20181203 for today.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2018-01-25  7:22 Stephen Rothwell
  2018-01-25  8:50 ` Leon Romanovsky
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2018-01-25  7:22 UTC (permalink / raw)
  To: Doug Ledford, Jason Gunthorpe
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Bart Van Assche

Hi all,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "init_rcu_head" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!

Caused by commit

  a11253142e6d ("IB/srpt: Rework multi-channel support")

I have used the rdma tree from next-20180119 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2017-07-31  2:07 Stephen Rothwell
  0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2017-07-31  2:07 UTC (permalink / raw)
  To: Doug Ledford
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Matan Barak

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/infiniband/hw/hns/hns_roce_eq.c: In function 'hns_roce_init_eq_table':
drivers/infiniband/hw/hns/hns_roce_eq.c:711:9: error: implicit declaration of function 'request_irq' [-Werror=implicit-function-declaration]
   ret = request_irq(eq_table->eq[j].irq, hns_roce_msi_x_interrupt,
         ^
drivers/infiniband/hw/hns/hns_roce_eq.c:726:3: error: implicit declaration of function 'free_irq' [-Werror=implicit-function-declaration]
   free_irq(eq_table->eq[j].irq, eq_table->eq + j);
   ^

Probably exposed by commit

  e89bf462b6be ("IB/hns: Support compile test for hns RoCE driver")

But maybe caused by another commit thet modified includes so that
linux/interrupt.h is not longer implictly included ...

I have used the rdma tree from next-20170728 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2017-04-21  1:42 Stephen Rothwell
  2017-04-21  1:58 ` Joe Perches
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2017-04-21  1:42 UTC (permalink / raw)
  To: Doug Ledford
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Joe Perches,
	Steve Wise

Hi Doug,

After merging the rdma tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/infiniband/hw/cxgb4/cm.c: In function 'send_connect':
drivers/infiniband/hw/cxgb4/cm.c:830:5: error: implicit declaration of function 'PDBG' [-Werror=implicit-function-declaration]
     PDBG("%s snd_isn %u\n", __func__, t6req->rsvd);
     ^

Caused by commit

  a9a42886d0b3 ("cxgb4: Convert PDBG to pr_debug")

I have used the rdma tree from next-20170420 for today.

There was another PDBG() missed in that file as well.
-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2017-02-15  0:30 Stephen Rothwell
  2017-02-15  1:05 ` Doug Ledford
  0 siblings, 1 reply; 68+ messages in thread
From: Stephen Rothwell @ 2017-02-15  0:30 UTC (permalink / raw)
  To: Doug Ledford, David Miller, Networking
  Cc: linux-next, linux-kernel, Michael Chan, Selvin Xavier, Eddie Wai,
	Devesh Sharma, Somnath Kotur, Sriharsha Basavapatna

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_net_ring_free':
drivers/infiniband/hw/bnxt_re/main.c:231:18: error: 'RING_ALLOC_REQ_RING_TYPE_CMPL' undeclared (first use in this function)
  req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
                  ^
drivers/infiniband/hw/bnxt_re/main.c:231:18: note: each undeclared identifier is reported only once for each function it appears in
drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_net_ring_alloc':
drivers/infiniband/hw/bnxt_re/main.c:271:18: error: 'RING_ALLOC_REQ_RING_TYPE_CMPL' undeclared (first use in this function)
  req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
                  ^

Caused by commit

  1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")

interacting with commit

  bac9a7e0f5d6 ("bnxt_en: Update to firmware interface spec 1.7.0.")

from the net-next tree.

I added this merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 15 Feb 2017 11:23:25 +1100
Subject: [PATCH] RDMA/bnxt_re: fix for "bnxt_en: Update to firmware interface spec 1.7.0."

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/infiniband/hw/bnxt_re/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index 6b9f1178050f..bd452a92b386 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -228,7 +228,7 @@ static int bnxt_re_net_ring_free(struct bnxt_re_dev *rdev, u16 fw_ring_id,
 	}
 
 	bnxt_re_init_hwrm_hdr(rdev, (void *)&req, HWRM_RING_FREE, -1, -1);
-	req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
+	req.ring_type = RING_ALLOC_REQ_RING_TYPE_L2_CMPL;
 	req.ring_id = cpu_to_le16(fw_ring_id);
 	bnxt_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&resp,
 			    sizeof(resp), DFLT_HWRM_CMD_TIMEOUT);
@@ -268,7 +268,7 @@ static int bnxt_re_net_ring_alloc(struct bnxt_re_dev *rdev, dma_addr_t *dma_arr,
 	/* Association of ring index with doorbell index and MSIX number */
 	req.logical_id = cpu_to_le16(map_index);
 	req.length = cpu_to_le32(ring_mask + 1);
-	req.ring_type = RING_ALLOC_REQ_RING_TYPE_CMPL;
+	req.ring_type = RING_ALLOC_REQ_RING_TYPE_L2_CMPL;
 	req.int_mode = RING_ALLOC_REQ_INT_MODE_MSIX;
 	bnxt_re_fill_fw_msg(&fw_msg, (void *)&req, sizeof(req), (void *)&resp,
 			    sizeof(resp), DFLT_HWRM_CMD_TIMEOUT);
-- 
2.10.2

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2016-09-27  1:23 Stephen Rothwell
  2016-09-27  5:04 ` Christoph Hellwig
  2016-09-28  1:43 ` Stephen Rothwell
  0 siblings, 2 replies; 68+ messages in thread
From: Stephen Rothwell @ 2016-09-27  1:23 UTC (permalink / raw)
  To: Doug Ledford; +Cc: linux-next, linux-kernel, Christoph Hellwig

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_hdev_setup_mrs':
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:7: error: implicit declaration of function 'ib_get_dma_mr' [-Werror=implicit-function-declaration]
  mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
       ^
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2317:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
     ^

Caused by commit

  5ef990f06bd7 ("IB/core: remove ib_get_dma_mr")

I have used the rdma tree from next-20160923 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 68+ messages in thread
* linux-next: build failure after merge of the rdma tree
@ 2016-01-13  1:35 ` Stephen Rothwell
  0 siblings, 0 replies; 68+ messages in thread
From: Stephen Rothwell @ 2016-01-13  1:35 UTC (permalink / raw)
  To: Doug Ledford, David Miller, netdev
  Cc: linux-next, linux-kernel, Maor Gottlieb, Achiad Shochat

Hi Doug,

After merging the rdma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_add':
drivers/infiniband/hw/mlx5/main.c:2255:6: error: too few arguments to function 'mlx5_ib_port_link_layer'
  if (mlx5_ib_port_link_layer(&dev->ib_dev) ==
      ^
drivers/infiniband/hw/mlx5/main.c:89:1: note: declared here
 mlx5_ib_port_link_layer(struct ib_device *device, u8 port_num)
 ^

Caused by commit

  ebd61f68e1c7 ("IB/mlx5: Support IB device's callback for getting the link layer")

interacting with commit

  038d2ef87572 ("IB/mlx5: Add flow steering support")

from the net-next tree.

I have added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 13 Jan 2016 12:30:50 +1100
Subject: [PATCH] IB/mlx5: merge fix for mlx5_ib_port_link_layer API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/infiniband/hw/mlx5/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 307a8c040a11..a2613d828578 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -2252,7 +2252,7 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev)
 			(1ull << IB_USER_VERBS_CMD_CLOSE_XRCD);
 	}
 
-	if (mlx5_ib_port_link_layer(&dev->ib_dev) ==
+	if (mlx5_ib_port_link_layer(&dev->ib_dev, 1) ==
 	    IB_LINK_LAYER_ETHERNET) {
 		dev->ib_dev.create_flow	= mlx5_ib_create_flow;
 		dev->ib_dev.destroy_flow = mlx5_ib_destroy_flow;
-- 
2.6.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply related	[flat|nested] 68+ messages in thread

end of thread, other threads:[~2020-02-26 17:25 UTC | newest]

Thread overview: 68+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-16  1:15 linux-next: build failure after merge of the rdma tree Stephen Rothwell
2016-03-16  6:49 ` Herbert Xu
2016-03-16 19:02   ` Doug Ledford
2016-03-16 20:41     ` Stephen Rothwell
2016-03-16 22:14     ` Ismail, Mustafa
  -- strict thread matches above, loose matches on Subject: below --
2020-02-26  2:51 Stephen Rothwell
2020-02-26  3:04 ` Devesh Sharma
2020-02-26 17:25 ` Jason Gunthorpe
2019-07-09  3:30 Stephen Rothwell
2019-07-09  7:04 ` Mark Zhang
2019-07-09  7:18   ` Leon Romanovsky
2019-07-09 12:43     ` Stephen Rothwell
2019-07-09 13:11       ` Leon Romanovsky
2019-07-09 12:46     ` Jason Gunthorpe
2019-07-10  1:04       ` Stephen Rothwell
2019-07-10  4:30         ` Stephen Rothwell
2019-07-16 23:28           ` Stephen Rothwell
2019-07-17  6:33             ` Masahiro Yamada
2019-07-17  7:45               ` Stephen Rothwell
2019-07-08  3:03 Stephen Rothwell
2019-07-08 14:09 ` Jason Gunthorpe
2019-07-08  2:57 Stephen Rothwell
2019-07-08 16:08 ` Jason Gunthorpe
2019-07-09  3:11   ` Stephen Rothwell
2019-07-25 18:32   ` Dennis Dalessandro
2019-07-01  4:14 Stephen Rothwell
2019-07-01  7:54 ` wangxi
2019-07-01 22:49   ` Jason Gunthorpe
2019-07-04  2:02 ` Stephen Rothwell
2019-07-04  2:04   ` Jason Gunthorpe
2019-07-04  2:10     ` oulijun
2019-07-04  4:07     ` wangxi
2019-07-04  4:10       ` wangxi
2019-07-04  6:31     ` oulijun
2019-07-05 13:15   ` Jason Gunthorpe
2019-07-05 14:59     ` Stephen Rothwell
2018-12-04  0:47 Stephen Rothwell
2018-12-04  1:52 ` Jason Gunthorpe
2018-12-04  9:42   ` Leon Romanovsky
2018-12-07  2:41     ` Stephen Rothwell
2018-12-05 12:25   ` Guy Levi(SW)
2018-12-05 22:58     ` Stephen Rothwell
2018-12-10  0:43       ` Changbin Du
2018-12-10 15:52       ` Masahiro Yamada
2018-01-25  7:22 Stephen Rothwell
2018-01-25  8:50 ` Leon Romanovsky
2018-01-25 16:08   ` Doug Ledford
2017-07-31  2:07 Stephen Rothwell
2017-04-21  1:42 Stephen Rothwell
2017-04-21  1:58 ` Joe Perches
2017-04-21  2:21   ` Doug Ledford
2017-04-21  2:23     ` Stephen Rothwell
2017-04-21  2:21   ` Stephen Rothwell
2017-02-15  0:30 Stephen Rothwell
2017-02-15  1:05 ` Doug Ledford
2017-02-15  5:09   ` Selvin Xavier
2016-09-27  1:23 Stephen Rothwell
2016-09-27  5:04 ` Christoph Hellwig
2016-09-27  5:48   ` Stephen Rothwell
2016-09-27 13:39     ` Christoph Hellwig
2016-09-27 17:15       ` Doug Ledford
2016-09-28  1:43 ` Stephen Rothwell
2016-09-28 15:00   ` Doug Ledford
2016-09-28 15:23     ` Greg KH
2016-09-28 15:26       ` Doug Ledford
2016-09-28 21:45     ` Stephen Rothwell
2016-01-13  1:35 Stephen Rothwell
2016-01-13  1:35 ` Stephen Rothwell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.