All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue
Date: Wed, 16 Mar 2016 07:54:19 -0700	[thread overview]
Message-ID: <20160316145419.GF6980@mtj.duckdns.org> (raw)
In-Reply-To: <20160315143852.GA381@amitoj-Inspiron-3542>

Hello,

On Tue, Mar 15, 2016 at 08:08:52PM +0530, Amitoj Kaur Chawla wrote:
> Replace deprecated create_singlethread_workqueue with
> alloc_ordered_workqueue.
> 
> Use alloc_ordered_workqueue for work like getting tx/rx frame sizes,
> resetting MPI processor,setting asic recovery bit as only one work
> item should be in queue/executing at any given time.

It'd be nice to explain why that is the case.  It's okay to be
speculative and ask the maintainers - e.g. say "Because of XXX and
YYY, the ordering seems necessary" and then in the section below "---"
ask the maintainer whether the assumption is correct.

> WQ_MEM_RECLAIM flag has been set to ensure execution context
> regardless of memory pressure since qdev->workqueue might be used in
> memory reclaim path.

Hmmm... why?  Network devices don't usually sit in the memory reclaim
path although there are nfs and storage-over-net cases.  I don't think
we have a clear rule here.  I'll ask around, but for now, I think it'd
be better to default to not set it.

Thanks.

-- 
tejun


      reply	other threads:[~2016-03-16 14:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15 14:38 [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue Amitoj Kaur Chawla
2016-03-16 14:54 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160316145419.GF6980@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=amitoj1606@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.