From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agNug-00053I-I8 for qemu-devel@nongnu.org; Wed, 16 Mar 2016 22:43:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agNuc-0006eh-GZ for qemu-devel@nongnu.org; Wed, 16 Mar 2016 22:43:50 -0400 Date: Thu, 17 Mar 2016 13:36:25 +1100 From: David Gibson Message-ID: <20160317023625.GL9032@voom> References: <1457974600-13828-1-git-send-email-clg@fr.ibm.com> <1457974600-13828-12-git-send-email-clg@fr.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CEK8Nf/5gFSxJ2tb" Content-Disposition: inline In-Reply-To: <1457974600-13828-12-git-send-email-clg@fr.ibm.com> Subject: Re: [Qemu-devel] [PATCH 11/17] ppc: Initialize AMOR in PAPR mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Thomas Huth , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --CEK8Nf/5gFSxJ2tb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 14, 2016 at 05:56:34PM +0100, C=E9dric Le Goater wrote: > From: Benjamin Herrenschmidt >=20 > Make sure we give the guest full authorization >=20 > Signed-off-by: Benjamin Herrenschmidt So my guess is that this is essential for 2.6 if the other patches affecting AMOR/AMR go in, but not otherwise. Is that correct? > --- > target-ppc/translate_init.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 68abd847a251..c921d9f53984 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -8542,6 +8542,7 @@ void cpu_ppc_set_papr(PowerPCCPU *cpu) > { > CPUPPCState *env =3D &cpu->env; > ppc_spr_t *lpcr =3D &env->spr_cb[SPR_LPCR]; > + ppc_spr_t *amor =3D &env->spr_cb[SPR_AMOR]; > =20 > /* PAPR always has exception vectors in RAM not ROM. To ensure this, > * MSR[IP] should never be set. > @@ -8563,6 +8564,9 @@ void cpu_ppc_set_papr(PowerPCCPU *cpu) > */ > env->spr[SPR_LPCR] =3D lpcr->default_value; > =20 > + /* Set a full AMOR so guest can use the AMR as it sees fit */ > + env->spr[SPR_AMOR] =3D amor->default_value =3D 0xffffffffffffffffull; > + > /* Tell KVM that we're in PAPR mode */ > if (kvm_enabled()) { > kvmppc_set_papr(cpu); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --CEK8Nf/5gFSxJ2tb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW6hgoAAoJEGw4ysog2bOSZhkQAIf3dCe+XlO4TaFJH/+9koAM zR7FaKMtBQTttazkn/BVBL98HEbX1wEZct2tyA/HlsjrcxhfiFbs6LWNPW9296p2 hvZv3xvco6JeE3cZDc3KZuoTdNQw/F0f43t6RNRaduh5l/TiVarwc+E3LMXCMI4m Qq+/HjMcLF++EqaWrYQmzktdDagk9hLPEa9c1ce1zJLIBiA2bRbFoU0fbQc9AB/+ RHFFugd4yN9mtsGPWR3FDeC/H8tELr4ptcphC8ZpJ9KOpZCdiOo/KZ2NIFF8JFFg Gpm2YeFN93ZxY8WtiiAIOmoT+4169PGXFNpVpzpzNiyrTB3vf3ndfzPdgQgITesV U8hgDClxy91Z5ITYoNfqR5oYdTECV/XslN3yRL4LEcMJHW8c1Jpwkzog9a7+1mhq KZdosbICMCPOnKSjwdebPXaQEpOER4SJXaHtVarU/8xt7+dAMIyUawGRBa5PiCdf JIpXZCf5kvR4vUkq4SIy2SwvfaAxN+4gZYiRF8yDO+CNwaMHeraAfrob/JMEDL4y iyGBsmi9+nVcVnU7mfIbdNMV4KFOixldn4D8UreNuOu20wmnMlQBV1ziwxCW3nIo L9PE/n1X71u7no+pFOE055u1EE7JmwxuTyAk8q2c4HKUz/LMzbM6Jtc4efnm+Zio eDdon9wZ/pel5iKu9IgQ =ISz5 -----END PGP SIGNATURE----- --CEK8Nf/5gFSxJ2tb--