From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agNvk-0006uE-Sy for qemu-devel@nongnu.org; Wed, 16 Mar 2016 22:44:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agNvg-0006vC-S3 for qemu-devel@nongnu.org; Wed, 16 Mar 2016 22:44:56 -0400 Date: Thu, 17 Mar 2016 13:45:31 +1100 From: David Gibson Message-ID: <20160317024531.GM9032@voom> References: <1457974600-13828-1-git-send-email-clg@fr.ibm.com> <20160315003942.GE15272@voom.fritz.box> <56E7C3B3.3030809@fr.ibm.com> <20160316011914.GA9032@voom> <56E92283.7020406@fr.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DVzT7whm/e/NFCC3" Content-Disposition: inline In-Reply-To: <56E92283.7020406@fr.ibm.com> Subject: Re: [Qemu-devel] [PATCH 00/17] ppc: preparing pnv landing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Thomas Huth , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --DVzT7whm/e/NFCC3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 16, 2016 at 10:08:19AM +0100, C=E9dric Le Goater wrote: > On 03/16/2016 02:19 AM, David Gibson wrote: > > On Tue, Mar 15, 2016 at 09:11:31AM +0100, C=E9dric Le Goater wrote: > >> On 03/15/2016 01:39 AM, David Gibson wrote: > >>> On Mon, Mar 14, 2016 at 05:56:23PM +0100, C=E9dric Le Goater wrote: > >>>> Hello, > >>>> > >>>> This is a first mini-serie of patches adding support for new ppc SPR= s. > >>>> They were taken from Ben's larger patchset adding the ppc powernv > >>>> platform and they should already be useful for the pseries guest > >>>> migration. > >>>> > >>>> Initial patches come from : > >>>> > >>>> https://github.com/ozbenh/qemu/commits/powernv > >>>> > >>>> The changes are mostly due to the rebase on Dave's 2.6 branch: > >>>> > >>>> https://github.com/dgibson/qemu/commits/ppc-for-2.6 > >>>> > >>>> A couple more are bisect and checkpatch fixes and finally some patch= es > >>>> were merge to reduce the noise. > >>>> > >>>> =20 > >>>> > >>>> The patchset is also available here:=20 > >>>> > >>>> https://github.com/legoater/qemu/commits/for-2.6 > >>>> > >>>> It was quickly tested with a pseries guest using KVM and TCG. > >>> > >>> Hmm.. do these all fix bugs with migration, or only some of them? > >> > >> Probably only some.=20 > >> > >> Initially, Thomas gave a shorter list which I expanded to a larger one= =20 > >> because of dependencies between patches and I didn't want to change too > >> much what Ben had sent. You had also reviewed a few. > >> > >>> The relevance is that things to fix migration should go into 2.6, but > >>> preparation work for powernv that doesn't fix bug shouldn't really be > >>> going in now, after the soft freeze and will need to wait for 2.7. > >> > >> OK. I will rework and keep the rest for 2.7.=20 > >=20 > > So, I'm ok with including (low risk) patches that aren't directly > > relevant to 2.6 if they're prereqs for patches that are relevant to > > 2.6. After all, reworking the patches isn't risk free either. Please > > mention why these patches are being included in the commit messages > > though. >=20 > Sure. =20 >=20 > >> Thomas, thanks for the review. I have identified a few things I need= =20 > >> to work on but may be, the patchset is still too large for 2.6 ? > >=20 > > It's not really a question of being too large, it's that I'm nervous > > about applying patches which touch the core translation code > > (e.g. fixes to HV mode tests) during soft freeze if they're not > > addressing a bug that's relevant to 2.6. >=20 > Could you please take a look at these two patches to see if they are=20 > relevant for 2.6 ? From my readings, they seem to be the only ones on=20 > the edge. >=20 > 06/17 ppc: Create cpu_ppc_set_papr() helper=20 > 11/17 ppc: Initialize AMOR in PAPR mode =20 Ok, I've replied to each of those. > but it makes sense to take them if we take : >=20 > 12/17 ppc: Fix writing to AMR/UAMOR (move hunk to 13) I'm not seeing a lot of cause to put this in for 2.6. The registers in question are already linked up to KVM, so migration should be ok, and I don't believe we have real use cases which are hitting the bugs this patch fixes. Except... > 13/17 ppc: Add POWER8 IAMR register (rework hunk) =2E.that I guess it's kind of a pre-req for this one, which could fix real migration bugs. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --DVzT7whm/e/NFCC3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW6hpLAAoJEGw4ysog2bOSCVYQAOAUbJfUvgx3bblz5mS4lNcI ndX7am2GLD4NTomd3W99cAXNd94Ds8PfXWSoiA/EvlFKmlM/ezp0U4iIFzJC8xiB XdHmeBTeUci0uPofpUhppkzWfnbWQWBP0p079QNhf7ZMfGKwECwy/VVjjYnrKQG4 WcV0kuHJdNQ2dCkaXFLcSCFlddCKUceN5xud2p/Kkcm8fz8FQrTkd6MU04zPTvx6 WH3xuQXzTAG3MzhMw/pcwYMSVv9+OXzsO/YjXDPRMAKbHU2hfvJ4wbuuUQALPixz u3j4CsM6RCtTnu3d3MUTZdS0+uG6yrs3mjcgDZuz8iEBx51xbLjsvgkGNwdU3Nbf 9M5O/zgem6Ipl5Q9iGqZG0XlqkozVQRsOAhFzdhizSL4a6ItfHGMXj7lOT8igs4K aduifmgvIP8H+TcslN1g1GsJ8we1B8zhmzkO+1vcWSZnnvaPhQ4bTFxwwsAQTP5L D2UHYCmrHiSsoBg/Gv6hJ6+hoGTl4gcHX/TnwxgGLoyGFFzuS/islq3lNg/t2WD4 E2mPY9kHq1ebzMGeZt2++wtyX/m8j7yTRPba/bn6KFRPzpdNbMXUknQzbRHkD8BZ YnYWpmhAxk6nBO3yziMV5m38VU1UNl3k4rlh6IBl46P2DTT+mQN1aqmxzErn0+nE yiNBSKH3cAVqAniwBNWu =4Lpy -----END PGP SIGNATURE----- --DVzT7whm/e/NFCC3--